From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Don't use thread_db on corefiles
Date: Thu, 13 Dec 2001 08:50:00 -0000 [thread overview]
Message-ID: <20011213114847.A17989@nevyn.them.org> (raw)
This patch fixes a really frustrating internal error when you open the
coredump of a multithreaded application. Depending on your kernel, either
the core has threads (corefile.c supports this just fine) or it doesn't.
Neither way will opening libthread_db work right.
This patch isn't quite complete, because strange things happen when you
connect to a remote target too. But fixing that requires a little more
fiddling.
Is this OK?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2001-12-13 Daniel Jacobowitz <drow@mvista.com>
* thread-db.c (thread_db_new_objfile): Don't use thread_db on
corefiles.
Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/thread-db.c,v
retrieving revision 1.18
diff -u -r1.18 thread-db.c
--- thread-db.c 2001/10/13 15:04:02 1.18
+++ thread-db.c 2001/12/13 16:43:08
@@ -482,7 +482,9 @@
{
td_err_e err;
- if (objfile == NULL)
+ /* Don't attempt to use thread_db on targets which can not run
+ (core files). */
+ if (objfile == NULL || !target_has_execution)
{
/* All symbols have been discarded. If the thread_db target is
active, deactivate it now. */
next reply other threads:[~2001-12-13 16:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-13 8:50 Daniel Jacobowitz [this message]
2001-12-13 10:57 ` Andrew Cagney
2001-12-13 11:37 ` Daniel Jacobowitz
2001-12-16 17:58 ` Daniel Jacobowitz
2001-12-16 21:32 ` Kevin Buettner
2001-12-17 8:34 ` Daniel Jacobowitz
2001-12-13 12:26 ` Michael Snyder
2001-12-13 12:31 ` Daniel Jacobowitz
2001-12-13 14:59 ` Michael Snyder
2001-12-13 15:04 ` Daniel Jacobowitz
2001-12-13 15:08 ` Michael Snyder
2001-12-13 15:11 ` Daniel Jacobowitz
2001-12-13 15:37 ` Andrew Cagney
2001-12-13 15:46 ` Daniel Jacobowitz
2001-12-13 17:14 ` Michael Snyder
2001-12-13 20:29 ` Daniel Jacobowitz
2001-12-14 18:12 ` Andrew Cagney
2001-12-14 18:25 ` Daniel Jacobowitz
2001-12-13 15:47 ` Michael Snyder
2001-12-13 15:57 ` Daniel Jacobowitz
2001-12-13 16:06 ` Daniel Jacobowitz
2001-12-13 17:31 ` Michael Snyder
2001-12-13 20:23 ` Daniel Jacobowitz
2001-12-14 15:43 ` Michael Snyder
2001-12-14 17:14 ` Daniel Jacobowitz
2001-12-17 11:40 ` Michael Snyder
2001-12-17 11:51 ` Daniel Jacobowitz
2001-12-13 17:26 ` Michael Snyder
2001-12-13 20:27 ` Daniel Jacobowitz
2001-12-14 18:31 ` Andrew Cagney
2001-12-14 18:36 ` Andrew Cagney
2001-12-14 18:42 ` Daniel Jacobowitz
2001-12-15 9:16 ` Andrew Cagney
2001-12-16 12:26 ` Daniel Jacobowitz
2001-12-16 13:29 ` Andrew Cagney
2001-12-16 17:02 ` Daniel Jacobowitz
2002-01-03 17:11 ` Michael Snyder
2002-01-04 10:25 ` Daniel Jacobowitz
2002-01-04 14:49 ` Michael Snyder
2002-01-04 17:28 ` Michael Snyder
2002-01-04 17:47 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011213114847.A17989@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox