Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: gdb-patches@sources.redhat.com, jimb@zwingli.cygnus.com
Subject: Re: RFA: maybe prototyped
Date: Fri, 16 Nov 2001 12:29:00 -0000	[thread overview]
Message-ID: <200111280624.AAA20950@duracef.shout.net> (raw)

Feedback:

. TYPE_FLAG_PROTOTYPED is documented in doc/gdbint.texinfo
  so that needs updating.

. I proofread the patch and found nothing else to kvetch about.

. I ran the test suite (native i686-pc-linux-gnu, v2 and v3 gcc compilers,
  stabs debugging format) and it found nothing to kvetch about either.
  I paid particular attention to callfuncs.c / t_float_values tests,
  which are the explicitly non-prototyped tests.

. Aside from the doco lacuna, looks okay by me.

Michael C


WARNING: multiple messages have this Message-ID
From: Michael Elizabeth Chastain <mec@shout.net>
To: gdb-patches@sources.redhat.com, jimb@zwingli.cygnus.com
Subject: Re: RFA: maybe prototyped
Date: Tue, 27 Nov 2001 22:24:00 -0000	[thread overview]
Message-ID: <200111280624.AAA20950@duracef.shout.net> (raw)
Message-ID: <20011127222400.Fv1DorPf42-ALHcSBkRbIECXDcrXACJfMDOZ9mCJtHI@z> (raw)

Feedback:

. TYPE_FLAG_PROTOTYPED is documented in doc/gdbint.texinfo
  so that needs updating.

. I proofread the patch and found nothing else to kvetch about.

. I ran the test suite (native i686-pc-linux-gnu, v2 and v3 gcc compilers,
  stabs debugging format) and it found nothing to kvetch about either.
  I paid particular attention to callfuncs.c / t_float_values tests,
  which are the explicitly non-prototyped tests.

. Aside from the doco lacuna, looks okay by me.

Michael C


             reply	other threads:[~2001-11-28  6:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-16 12:29 Michael Elizabeth Chastain [this message]
2001-11-27 22:24 ` Michael Elizabeth Chastain
  -- strict thread matches above, loose matches on Subject: below --
2001-11-16 12:17 Jim Blandy
2001-11-27 20:51 ` Jim Blandy
2001-12-01 15:48 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111280624.AAA20950@duracef.shout.net \
    --to=mec@shout.net \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@zwingli.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox