From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10819-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 3941 invoked by alias); 28 Nov 2001 06:24:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 3920 invoked from network); 28 Nov 2001 06:24:01 -0000
Received: from unknown (HELO duracef.shout.net) (204.253.184.12)
  by hostedprojects.ges.redhat.com with SMTP; 28 Nov 2001 06:24:01 -0000
Received: (from mec@localhost)
	by duracef.shout.net (8.8.7/8.8.7) id AAA20950;
	Wed, 28 Nov 2001 00:24:01 -0600
Date: Fri, 16 Nov 2001 12:29:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200111280624.AAA20950@duracef.shout.net>
To: gdb-patches@sources.redhat.com, jimb@zwingli.cygnus.com
Subject: Re: RFA: maybe prototyped
X-SW-Source: 2001-11/txt/msg00315.txt.bz2

Feedback:

. TYPE_FLAG_PROTOTYPED is documented in doc/gdbint.texinfo
  so that needs updating.

. I proofread the patch and found nothing else to kvetch about.

. I ran the test suite (native i686-pc-linux-gnu, v2 and v3 gcc compilers,
  stabs debugging format) and it found nothing to kvetch about either.
  I paid particular attention to callfuncs.c / t_float_values tests,
  which are the explicitly non-prototyped tests.

. Aside from the doco lacuna, looks okay by me.

Michael C


From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Elizabeth Chastain <mec@shout.net>
To: gdb-patches@sources.redhat.com, jimb@zwingli.cygnus.com
Subject: Re: RFA: maybe prototyped
Date: Tue, 27 Nov 2001 22:24:00 -0000
Message-ID: <200111280624.AAA20950@duracef.shout.net>
X-SW-Source: 2001-11/msg00530.html
Message-ID: <20011127222400.Fv1DorPf42-ALHcSBkRbIECXDcrXACJfMDOZ9mCJtHI@z>

Feedback:

. TYPE_FLAG_PROTOTYPED is documented in doc/gdbint.texinfo
  so that needs updating.

. I proofread the patch and found nothing else to kvetch about.

. I ran the test suite (native i686-pc-linux-gnu, v2 and v3 gcc compilers,
  stabs debugging format) and it found nothing to kvetch about either.
  I paid particular attention to callfuncs.c / t_float_values tests,
  which are the explicitly non-prototyped tests.

. Aside from the doco lacuna, looks okay by me.

Michael C