* [RFA] Remove redundant initialization of auto_solib_add
@ 2001-10-29 20:30 Fred Fish
2001-10-29 22:20 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Fred Fish @ 2001-10-29 20:30 UTC (permalink / raw)
To: gdb-patches
The default value for auto_solib_add is a compile time constant of 1.
There is no need to explicitly initialize it at initialization.
-Fred
2001-10-29 Fred Fish <fnf@redhat.com>
* win32-nat.c (_initialize_inftarg): Remove unnecessary
initialization of auto_solib_add, it defaults to 1.
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.33
diff -u -p -r1.33 win32-nat.c
--- win32-nat.c 2001/10/26 09:29:31 1.33
+++ win32-nat.c 2001/10/30 04:27:54
@@ -1453,7 +1453,6 @@ _initialize_inftarg (void)
"Load dll library symbols from FILE.");
c->completer = filename_completer;
- auto_solib_add = 1;
add_com_alias ("sharedlibrary", "dll-symbols", class_alias, 1);
add_show_from_set (add_set_cmd ("new-console", class_support, var_boolean,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] Remove redundant initialization of auto_solib_add
2001-10-29 20:30 [RFA] Remove redundant initialization of auto_solib_add Fred Fish
@ 2001-10-29 22:20 ` Kevin Buettner
2001-10-30 12:22 ` Christopher Faylor
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2001-10-29 22:20 UTC (permalink / raw)
To: Fred Fish, gdb-patches
On Oct 29, 9:28pm, Fred Fish wrote:
> The default value for auto_solib_add is a compile time constant of 1.
> There is no need to explicitly initialize it at initialization.
>
> -Fred
>
> 2001-10-29 Fred Fish <fnf@redhat.com>
>
> * win32-nat.c (_initialize_inftarg): Remove unnecessary
> initialization of auto_solib_add, it defaults to 1.
This one is fine too.
(Actually, I'm not the maintainer for win32-nat.c, but it does deal
with shared libraries and it seems pretty obvious anyway...)
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Remove redundant initialization of auto_solib_add
2001-10-29 22:20 ` Kevin Buettner
@ 2001-10-30 12:22 ` Christopher Faylor
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Faylor @ 2001-10-30 12:22 UTC (permalink / raw)
To: gdb-patches
On Mon, Oct 29, 2001 at 11:20:23PM -0700, Kevin Buettner wrote:
>On Oct 29, 9:28pm, Fred Fish wrote:
>
>> The default value for auto_solib_add is a compile time constant of 1.
>> There is no need to explicitly initialize it at initialization.
>>
>> -Fred
>>
>> 2001-10-29 Fred Fish <fnf@redhat.com>
>>
>> * win32-nat.c (_initialize_inftarg): Remove unnecessary
>> initialization of auto_solib_add, it defaults to 1.
>
>This one is fine too.
>
>(Actually, I'm not the maintainer for win32-nat.c, but it does deal
>with shared libraries and it seems pretty obvious anyway...)
It is fine. I think that this was actually debugging code that was
accidentally checked in.
cgf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-10-30 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-29 20:30 [RFA] Remove redundant initialization of auto_solib_add Fred Fish
2001-10-29 22:20 ` Kevin Buettner
2001-10-30 12:22 ` Christopher Faylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox