[RFA] Remove redundant initialization of auto_solib_add

[RFA] Remove redundant initialization of auto_solib_add

[Fred Fish]

The default value for auto_solib_add is a compile time constant of 1.
There is no need to explicitly initialize it at initialization.

-Fred

  2001-10-29  Fred Fish  <fnf@redhat.com>

	* win32-nat.c (_initialize_inftarg): Remove unnecessary
	initialization of auto_solib_add, it defaults to 1.

Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.33
diff -u -p -r1.33 win32-nat.c
--- win32-nat.c	2001/10/26 09:29:31	1.33
+++ win32-nat.c	2001/10/30 04:27:54
@@ -1453,7 +1453,6 @@ _initialize_inftarg (void)
 	       "Load dll library symbols from FILE.");
   c->completer = filename_completer;
 
-  auto_solib_add = 1;
   add_com_alias ("sharedlibrary", "dll-symbols", class_alias, 1);
 
   add_show_from_set (add_set_cmd ("new-console", class_support, var_boolean,

Re: [RFA] Remove redundant initialization of auto_solib_add

[Kevin Buettner]

On Oct 29,  9:28pm, Fred Fish wrote:

> The default value for auto_solib_add is a compile time constant of 1.
> There is no need to explicitly initialize it at initialization.
> 
> -Fred
> 
>   2001-10-29  Fred Fish  <fnf@redhat.com>
> 
> 	* win32-nat.c (_initialize_inftarg): Remove unnecessary
> 	initialization of auto_solib_add, it defaults to 1.

This one is fine too.

(Actually, I'm not the maintainer for win32-nat.c, but it does deal
with shared libraries and it seems pretty obvious anyway...)

Kevin

Re: [RFA] Remove redundant initialization of auto_solib_add

[Christopher Faylor]

On Mon, Oct 29, 2001 at 11:20:23PM -0700, Kevin Buettner wrote:
>On Oct 29,  9:28pm, Fred Fish wrote:
>
>> The default value for auto_solib_add is a compile time constant of 1.
>> There is no need to explicitly initialize it at initialization.
>> 
>> -Fred
>> 
>>   2001-10-29  Fred Fish  <fnf@redhat.com>
>> 
>> 	* win32-nat.c (_initialize_inftarg): Remove unnecessary
>> 	initialization of auto_solib_add, it defaults to 1.
>
>This one is fine too.
>
>(Actually, I'm not the maintainer for win32-nat.c, but it does deal
>with shared libraries and it seems pretty obvious anyway...)

It is fine.  I think that this was actually debugging code that was
accidentally checked in.

cgf