From: Mark Kettenis <kettenis@wins.uva.nl>
To: ac131313@cygnus.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc/rfa(DavidT?)] Move DOUBLEST to doublest.{h,c}
Date: Mon, 30 Jul 2001 14:41:00 -0000 [thread overview]
Message-ID: <200107302128.f6ULSI508576@delius.kettenis.local> (raw)
In-Reply-To: <3B65707C.10003@cygnus.com>
Date: Mon, 30 Jul 2001 10:34:36 -0400
From: Andrew Cagney <ac131313@cygnus.com>
>> > * config/m88k/tm-m88k.h: Include "doublest.h".
>> > * config/m68k/tm-m68k.h, config/i960/tm-i960.h: Ditto.
>> > * config/i386/xm-nbsd.h, config/i386/xm-linux.h: Ditto.
>> > * config/i386/xm-i386gnu.h, config/i386/xm-go32.h: Ditto.
>> > * config/i386/xm-fbsd.h, config/i386/tm-symmetry.h: Ditto.
>
>
> Why are you including "doublest.h" from various tm.h and xm.h files?
> Most of them don't use DOUBLEST at all, so this seems wrong to me.
Headers such as tm-m88k.h contain macros that refer to functions such as
store_floating(). I moved those functions to doublest.h.
I see, but how about the i386/xm-*.h files? I'm asking since I'm
thinking about replacing most of them with a single xm-i386.h with the
following contents:
/* FIXME: kettenis/2001-07-29: Get rid of HOST_BYTE_ORDER when Andrew
has erradicated it from the sources. */
#define HOST_BYTE_ORDER LITTLE_ENDIAN
#define HOST_FLOAT_FORMAT &floatformat_ieee_single_little
#define HOST_DOUBLE_FORMAT &floatformat_ieee_double_little
#define HOST_LONG_DOUBLE_FORMAT &floatformat_i387_ext
Mark
Yes, ulgh :-)
Andrew
next prev parent reply other threads:[~2001-07-30 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-16 8:18 Andrew Cagney
2001-07-29 12:34 ` Andrew Cagney
2001-07-30 7:09 ` Mark Kettenis
2001-07-30 7:34 ` Andrew Cagney
2001-07-30 14:41 ` Mark Kettenis [this message]
2001-07-30 15:34 ` Andrew Cagney
2001-07-30 21:50 ` Andrew Cagney
2001-07-31 14:37 ` Andrew Cagney
2001-08-01 11:42 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107302128.f6ULSI508576@delius.kettenis.local \
--to=kettenis@wins.uva.nl \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox