Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Mark Kettenis <kettenis@wins.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc/rfa(DavidT?)] Move DOUBLEST to doublest.{h,c}
Date: Mon, 30 Jul 2001 15:34:00 -0000	[thread overview]
Message-ID: <3B65E10B.9000706@cygnus.com> (raw)
In-Reply-To: <200107302128.f6ULSI508576@delius.kettenis.local>

>    Headers such as tm-m88k.h contain macros that refer to functions such as 
>    store_floating().  I moved those functions to doublest.h.
> 
> I see, but how about the i386/xm-*.h files?  I'm asking since I'm
> thinking about replacing most of them with a single xm-i386.h with the
> following contents:


I was only checking for references to the functions I moved.


>    /* FIXME: kettenis/2001-07-29: Get rid of HOST_BYTE_ORDER when Andrew
>       has erradicated it from the sources.  */
>    #define HOST_BYTE_ORDER LITTLE_ENDIAN
> 
>    #define HOST_FLOAT_FORMAT &floatformat_ieee_single_little
>    #define HOST_DOUBLE_FORMAT &floatformat_ieee_double_little
>    #define HOST_LONG_DOUBLE_FORMAT &floatformat_i387_ext


I'd include "floatformat.h".  Is there an x86 system that doesn't have 
long double?  I've a memory of someone pointing this out when I recently 
  changed the i387 float conversion code.

FYI, I also recently added the below to the doco.  It was an attempt at 
summarising an earlier discussion about an include file policy.

	Andrew

@subsection Include Files

All @file{.c} files should include @file{defs.h} first.

All @file{.c} files should explicitly include the headers for any
declarations they refer to.  They should not rely on files being
included indirectly.

With the exception of the global definitions supplied by @file{defs.h},
a header file should explictily include the header declaring any
@code{typedefs} et.al.@: it refers to.

@code{extern} declarations should never appear in @code{.c} files.

All include files should be wrapped in:

@example
#ifndef INCLUDE_FILE_NAME_H
#define INCLUDE_FILE_NAME_H
header body
#endif
@end example





  reply	other threads:[~2001-07-30 15:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-16  8:18 Andrew Cagney
2001-07-29 12:34 ` Andrew Cagney
2001-07-30  7:09   ` Mark Kettenis
2001-07-30  7:34     ` Andrew Cagney
2001-07-30 14:41       ` Mark Kettenis
2001-07-30 15:34         ` Andrew Cagney [this message]
2001-07-30 21:50           ` Andrew Cagney
2001-07-31 14:37             ` Andrew Cagney
2001-08-01 11:42   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B65E10B.9000706@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@wins.uva.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox