From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Kettenis To: ac131313@cygnus.com Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc/rfa(DavidT?)] Move DOUBLEST to doublest.{h,c} Date: Mon, 30 Jul 2001 14:41:00 -0000 Message-id: <200107302128.f6ULSI508576@delius.kettenis.local> References: <3B5305B5.4070207@cygnus.com> <3B64653B.90607@cygnus.com> <3B65707C.10003@cygnus.com> X-SW-Source: 2001-07/msg00727.html Date: Mon, 30 Jul 2001 10:34:36 -0400 From: Andrew Cagney >> > * config/m88k/tm-m88k.h: Include "doublest.h". >> > * config/m68k/tm-m68k.h, config/i960/tm-i960.h: Ditto. >> > * config/i386/xm-nbsd.h, config/i386/xm-linux.h: Ditto. >> > * config/i386/xm-i386gnu.h, config/i386/xm-go32.h: Ditto. >> > * config/i386/xm-fbsd.h, config/i386/tm-symmetry.h: Ditto. > > > Why are you including "doublest.h" from various tm.h and xm.h files? > Most of them don't use DOUBLEST at all, so this seems wrong to me. Headers such as tm-m88k.h contain macros that refer to functions such as store_floating(). I moved those functions to doublest.h. I see, but how about the i386/xm-*.h files? I'm asking since I'm thinking about replacing most of them with a single xm-i386.h with the following contents: /* FIXME: kettenis/2001-07-29: Get rid of HOST_BYTE_ORDER when Andrew has erradicated it from the sources. */ #define HOST_BYTE_ORDER LITTLE_ENDIAN #define HOST_FLOAT_FORMAT &floatformat_ieee_single_little #define HOST_DOUBLE_FORMAT &floatformat_ieee_double_little #define HOST_LONG_DOUBLE_FORMAT &floatformat_i387_ext Mark Yes, ulgh :-) Andrew