Re: [PATCH, RFA]: Skip mi test when UI_OUT but mi support isn't present

Re: [PATCH, RFA]: Skip mi test when UI_OUT but mi support isn't present

[Kevin Buettner]

What ever became of the patch below?  (It doesn't look like it's
been checked in.)

On Jan 21,  9:50am, Fernando Nasser wrote:
> Subject: Re: [PATCH, RFA]: Skip mi test when UI_OUT but mi support isn't p
> Mark Kettenis wrote:
> > 
> > Ever since the switch to UI_OUT, the mi tests are no longer skipped if
> > mi support wasn't compiled in.  The attached patch fixes this.  I left
> > the pre-UI_OUT stuff in since it is still possible to compile GDB
> > wuithout UI_OUT.
> > 
> 
> Thank you for catching this Mark.
> 
> Please check it in.
> 
> Fernando
> 
> 
> 
> > Mark
> > 
> > 2001-01-20  Mark Kettenis  <kettenis@gnu.org>
> > 
> >         * mi-support.exp (mi_gdb_start): Skip mi tests if -i flag is
> >         recognized (i.e. if GDB was compiled with UI_OUT, but the mi
> >         interpreter wasn't recognized (because it wasn't compiled in).
> > 
> > Index: testsuite/lib/mi-support.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 mi-support.exp
> > --- mi-support.exp      2000/12/20 21:24:28     1.3
> > +++ mi-support.exp      2001/01/20 22:24:58
> > @@ -135,6 +135,11 @@ proc mi_gdb_start { } {
> >             remote_close host;
> >             return -1;
> >         }
> > +       -re ".*Interpreter `mi' unrecognized." {
> > +           untested "Skip mi tests (not compiled with mi support)."
> > +           remote_close host;
> > +           return -1;
> > +       }
> >         timeout {
> >             perror "(timeout) GDB never initialized after 10 seconds."
> >             remote_close host;
> 
> -- 
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9
>-- End of excerpt from Fernando Nasser

Re: [PATCH, RFA]: Skip mi test when UI_OUT but mi support isn't present

[Mark Kettenis]

   Date: Wed, 28 Mar 2001 13:53:33 -0700
   From: Kevin Buettner <kevinb@cygnus.com>

   What ever became of the patch below?  (It doesn't look like it's
   been checked in.)

It is checked in.  Problems with a sticky tag?  Or perhaps you
couldn't find the ChangeLog entry?  Since mi-support.exp has the lines

# Local variables: 
# change-log-default-name: "../gdb.mi/ChangeLog-mi"
# End: 

Emacs put the entry in the entry in a somehwat unobvious place.  I
left it there assuming the intention was to keep all MI-related stuff
together.

Mark

Re: [PATCH, RFA]: Skip mi test when UI_OUT but mi support isn't present

[Kevin Buettner]

On Mar 28, 11:06pm, Mark Kettenis wrote:

>    Date: Wed, 28 Mar 2001 13:53:33 -0700
>    From: Kevin Buettner <kevinb@cygnus.com>
> 
>    What ever became of the patch below?  (It doesn't look like it's
>    been checked in.)
> 
> It is checked in.  Problems with a sticky tag?  Or perhaps you
> couldn't find the ChangeLog entry?  Since mi-support.exp has the lines
> 
> # Local variables: 
> # change-log-default-name: "../gdb.mi/ChangeLog-mi"
> # End: 
> 
> Emacs put the entry in the entry in a somehwat unobvious place.  I
> left it there assuming the intention was to keep all MI-related stuff
> together.

Yeah.  It's the ChangeLog location that confused me.

Thanks,

Kevin