[RFA]: Remove unused code in event-loop.c

[RFA]: Remove unused code in event-loop.c

[Eli Zaretskii]

I bumped into this while working on the DJGPP `select' bug.  That
#error directive was sitting there since GDB 5.0 was released, with no
one complaining AFAIK.  It looks like it would be safe to remove it
now.

Okay?

2001-03-24  Eli Zaretskii  <eliz@is.elta.co.il>

	* event-loop.c (toplevel) [!HAVE_POLL] [NO_FD_SET]: Remove unused
	definitions for SELECT, NBBY, FD_SETSIZE, NFDBITS, and MASK_SIZE.

--- gdb/event-loop.c~0	Wed Jan 31 17:46:34 2001
+++ gdb/event-loop.c	Sat Mar 24 18:59:54 2001
@@ -38,52 +38,6 @@
 #include <setjmp.h>
 #include <sys/time.h>
 
-/* Type of the mask arguments to select. */
-
-#ifndef HAVE_POLL
-#ifdef NO_FD_SET
-/* All this stuff below is not required if select is used as God(tm)
-   intended, with the FD_* macros.  Are there any implementations of
-   select which don't have FD_SET and other standard FD_* macros?  I
-   don't think there are, but if I'm wrong, we need to catch them.  */
-#error FD_SET must be defined if select function is to be used!
-
-#ifndef _AIX
-typedef long fd_mask;
-#endif
-#if defined(_IBMR2)
-#define SELECT_MASK void
-#else
-#define SELECT_MASK int
-#endif /* !_IBMR2 */
-
-/* Define "NBBY" (number of bits per byte) if it's not already defined. */
-
-#ifndef NBBY
-#define NBBY 8
-#endif
-
-/* Define the number of fd_masks in an fd_set */
-
-#ifndef FD_SETSIZE
-#ifdef OPEN_MAX
-#define FD_SETSIZE OPEN_MAX
-#else
-#define FD_SETSIZE 256
-#endif
-#endif
-#if !defined(howmany)
-#define howmany(x, y) (((x)+((y)-1))/(y))
-#endif
-#ifndef NFDBITS
-#define NFDBITS NBBY*sizeof(fd_mask)
-#endif
-#define MASK_SIZE howmany(FD_SETSIZE, NFDBITS)
-
-#endif /* NO_FD_SET */
-#endif /* !HAVE_POLL */
-
-
 typedef struct gdb_event gdb_event;
 typedef void (event_handler_func) (int);
 

Re: [RFA]: Remove unused code in event-loop.c

[Elena Zannoni]

Eli Zaretskii writes:
 > I bumped into this while working on the DJGPP `select' bug.  That
 > #error directive was sitting there since GDB 5.0 was released, with no
 > one complaining AFAIK.  It looks like it would be safe to remove it
 > now.
 > 
 > Okay?
 > 

Fine with me.

Thanks
Elena

 > 2001-03-24  Eli Zaretskii  <eliz@is.elta.co.il>
 > 
 > 	* event-loop.c (toplevel) [!HAVE_POLL] [NO_FD_SET]: Remove unused
 > 	definitions for SELECT, NBBY, FD_SETSIZE, NFDBITS, and MASK_SIZE.
 > 
 > --- gdb/event-loop.c~0	Wed Jan 31 17:46:34 2001
 > +++ gdb/event-loop.c	Sat Mar 24 18:59:54 2001
 > @@ -38,52 +38,6 @@
 >  #include <setjmp.h>
 >  #include <sys/time.h>
 >  
 > -/* Type of the mask arguments to select. */
 > -
 > -#ifndef HAVE_POLL
 > -#ifdef NO_FD_SET
 > -/* All this stuff below is not required if select is used as God(tm)
 > -   intended, with the FD_* macros.  Are there any implementations of
 > -   select which don't have FD_SET and other standard FD_* macros?  I
 > -   don't think there are, but if I'm wrong, we need to catch them.  */
 > -#error FD_SET must be defined if select function is to be used!
 > -
 > -#ifndef _AIX
 > -typedef long fd_mask;
 > -#endif
 > -#if defined(_IBMR2)
 > -#define SELECT_MASK void
 > -#else
 > -#define SELECT_MASK int
 > -#endif /* !_IBMR2 */
 > -
 > -/* Define "NBBY" (number of bits per byte) if it's not already defined. */
 > -
 > -#ifndef NBBY
 > -#define NBBY 8
 > -#endif
 > -
 > -/* Define the number of fd_masks in an fd_set */
 > -
 > -#ifndef FD_SETSIZE
 > -#ifdef OPEN_MAX
 > -#define FD_SETSIZE OPEN_MAX
 > -#else
 > -#define FD_SETSIZE 256
 > -#endif
 > -#endif
 > -#if !defined(howmany)
 > -#define howmany(x, y) (((x)+((y)-1))/(y))
 > -#endif
 > -#ifndef NFDBITS
 > -#define NFDBITS NBBY*sizeof(fd_mask)
 > -#endif
 > -#define MASK_SIZE howmany(FD_SETSIZE, NFDBITS)
 > -
 > -#endif /* NO_FD_SET */
 > -#endif /* !HAVE_POLL */
 > -
 > -
 >  typedef struct gdb_event gdb_event;
 >  typedef void (event_handler_func) (int);
 >  
 > 

Re: [RFA]: Remove unused code in event-loop.c

[Eli Zaretskii]

On Sun, 25 Mar 2001, Elena Zannoni wrote:

> Eli Zaretskii writes:
>  > I bumped into this while working on the DJGPP `select' bug.  That
>  > #error directive was sitting there since GDB 5.0 was released, with no
>  > one complaining AFAIK.  It looks like it would be safe to remove it
>  > now.
>  > 
>  > Okay?
>  > 
> 
> Fine with me.

Committed.  Thanks for the prompt reply.

> 
> Thanks
> Elena
> 
>  > 2001-03-24  Eli Zaretskii  <eliz@is.elta.co.il>
>  > 
>  > 	* event-loop.c (toplevel) [!HAVE_POLL] [NO_FD_SET]: Remove unused
>  > 	definitions for SELECT, NBBY, FD_SETSIZE, NFDBITS, and MASK_SIZE.
>  > 
>  > --- gdb/event-loop.c~0	Wed Jan 31 17:46:34 2001
>  > +++ gdb/event-loop.c	Sat Mar 24 18:59:54 2001
>  > @@ -38,52 +38,6 @@
>  >  #include <setjmp.h>
>  >  #include <sys/time.h>
>  >  
>  > -/* Type of the mask arguments to select. */
>  > -
>  > -#ifndef HAVE_POLL
>  > -#ifdef NO_FD_SET
>  > -/* All this stuff below is not required if select is used as God(tm)
>  > -   intended, with the FD_* macros.  Are there any implementations of
>  > -   select which don't have FD_SET and other standard FD_* macros?  I
>  > -   don't think there are, but if I'm wrong, we need to catch them.  */
>  > -#error FD_SET must be defined if select function is to be used!
>  > -
>  > -#ifndef _AIX
>  > -typedef long fd_mask;
>  > -#endif
>  > -#if defined(_IBMR2)
>  > -#define SELECT_MASK void
>  > -#else
>  > -#define SELECT_MASK int
>  > -#endif /* !_IBMR2 */
>  > -
>  > -/* Define "NBBY" (number of bits per byte) if it's not already defined. */
>  > -
>  > -#ifndef NBBY
>  > -#define NBBY 8
>  > -#endif
>  > -
>  > -/* Define the number of fd_masks in an fd_set */
>  > -
>  > -#ifndef FD_SETSIZE
>  > -#ifdef OPEN_MAX
>  > -#define FD_SETSIZE OPEN_MAX
>  > -#else
>  > -#define FD_SETSIZE 256
>  > -#endif
>  > -#endif
>  > -#if !defined(howmany)
>  > -#define howmany(x, y) (((x)+((y)-1))/(y))
>  > -#endif
>  > -#ifndef NFDBITS
>  > -#define NFDBITS NBBY*sizeof(fd_mask)
>  > -#endif
>  > -#define MASK_SIZE howmany(FD_SETSIZE, NFDBITS)
>  > -
>  > -#endif /* NO_FD_SET */
>  > -#endif /* !HAVE_POLL */
>  > -
>  > -
>  >  typedef struct gdb_event gdb_event;
>  >  typedef void (event_handler_func) (int);
>  >  
>  > 
>