From: Eli Zaretskii <eliz@is.elta.co.il>
To: Elena Zannoni <ezannoni@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Remove unused code in event-loop.c
Date: Mon, 26 Mar 2001 03:38:00 -0000 [thread overview]
Message-ID: <Pine.SUN.3.91.1010326133601.8356F-100000@is> (raw)
In-Reply-To: <15038.17929.508336.564720@kwikemart.cygnus.com>
On Sun, 25 Mar 2001, Elena Zannoni wrote:
> Eli Zaretskii writes:
> > I bumped into this while working on the DJGPP `select' bug. That
> > #error directive was sitting there since GDB 5.0 was released, with no
> > one complaining AFAIK. It looks like it would be safe to remove it
> > now.
> >
> > Okay?
> >
>
> Fine with me.
Committed. Thanks for the prompt reply.
>
> Thanks
> Elena
>
> > 2001-03-24 Eli Zaretskii <eliz@is.elta.co.il>
> >
> > * event-loop.c (toplevel) [!HAVE_POLL] [NO_FD_SET]: Remove unused
> > definitions for SELECT, NBBY, FD_SETSIZE, NFDBITS, and MASK_SIZE.
> >
> > --- gdb/event-loop.c~0 Wed Jan 31 17:46:34 2001
> > +++ gdb/event-loop.c Sat Mar 24 18:59:54 2001
> > @@ -38,52 +38,6 @@
> > #include <setjmp.h>
> > #include <sys/time.h>
> >
> > -/* Type of the mask arguments to select. */
> > -
> > -#ifndef HAVE_POLL
> > -#ifdef NO_FD_SET
> > -/* All this stuff below is not required if select is used as God(tm)
> > - intended, with the FD_* macros. Are there any implementations of
> > - select which don't have FD_SET and other standard FD_* macros? I
> > - don't think there are, but if I'm wrong, we need to catch them. */
> > -#error FD_SET must be defined if select function is to be used!
> > -
> > -#ifndef _AIX
> > -typedef long fd_mask;
> > -#endif
> > -#if defined(_IBMR2)
> > -#define SELECT_MASK void
> > -#else
> > -#define SELECT_MASK int
> > -#endif /* !_IBMR2 */
> > -
> > -/* Define "NBBY" (number of bits per byte) if it's not already defined. */
> > -
> > -#ifndef NBBY
> > -#define NBBY 8
> > -#endif
> > -
> > -/* Define the number of fd_masks in an fd_set */
> > -
> > -#ifndef FD_SETSIZE
> > -#ifdef OPEN_MAX
> > -#define FD_SETSIZE OPEN_MAX
> > -#else
> > -#define FD_SETSIZE 256
> > -#endif
> > -#endif
> > -#if !defined(howmany)
> > -#define howmany(x, y) (((x)+((y)-1))/(y))
> > -#endif
> > -#ifndef NFDBITS
> > -#define NFDBITS NBBY*sizeof(fd_mask)
> > -#endif
> > -#define MASK_SIZE howmany(FD_SETSIZE, NFDBITS)
> > -
> > -#endif /* NO_FD_SET */
> > -#endif /* !HAVE_POLL */
> > -
> > -
> > typedef struct gdb_event gdb_event;
> > typedef void (event_handler_func) (int);
> >
> >
>
prev parent reply other threads:[~2001-03-26 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-24 12:39 Eli Zaretskii
2001-03-25 11:24 ` Elena Zannoni
2001-03-26 3:38 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1010326133601.8356F-100000@is \
--to=eliz@is.elta.co.il \
--cc=ezannoni@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox