Re: gdb-patches Digest 11 Feb 2001 23:49:53 -0000 Issue 545

Re: gdb-patches Digest 11 Feb 2001 23:49:53 -0000 Issue 545

[Michael Elizabeth Chastain]

Jeff,

>     int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr,
>                                    int len, int write,
>                                    struct target_ops * target));

Is your tree up to date?  My tree has this in gdb/target.h:

    int (*to_xfer_memory) (CORE_ADDR memaddr, char *myaddr,
                           int len, int write,
                           struct mem_attrib *attrib,
                           struct target_ops *target);

JT added this on 2001-01-23 and broke a bunch of targets,
including hpux 10.20.

I fixed hpux 10.20 (child_xfer_memory in hppah-nat.c) but I didn't
do anything about hpux 11.

Michael

Re: gdb-patches Digest 11 Feb 2001 23:49:53 -0000 Issue 545

[Jeffrey A Law]

  In message < 200102161810.KAA00700@bosch.cygnus.com >you write:
  > Jeff,
  > 
  > >     int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr,
  > >                                    int len, int write,
  > >                                    struct target_ops * target));
  > 
  > Is your tree up to date?  My tree has this in gdb/target.h:
Ahh.  Mine probably has a sticky date tag from trying to track down
what change broke hpux11 ttrace.  My goof.

  > I fixed hpux 10.20 (child_xfer_memory in hppah-nat.c) but I didn't
  > do anything about hpux 11.
In that case Paul's patch is probably correct.

jeff

Re: gdb-patches Digest 11 Feb 2001 23:49:53 -0000 Issue 545

[Andrew Cagney]

Jeffrey A Law wrote:

>   > 2001-02-11  Paul Hilfinger  <hilfingr@nile.gnat.com>
>   >
>   >     * hpux-thread.c (save_inferior_pid): Change call to make_cleanup
>   >     to make arguments conform.
>   >     (restore_inferior_pid): Change signature to that expected by
>   >     make_cleanup.
> No comment on this one -- I'm not that familiar with the new guidelines
> for make_cleanup.  I'll let Andrew comment on this.

It was rejected.  It was hiding a type compatibility problem by simply
casting it.

>   > 2001-02-11  Paul Hilfinger  <hilfingr@lisbon.int.act-europe.fr>
>   > 
>   >     * hpux-thread.c (hpux_thread_xfer_memory): Add mem_attrib 
>   >     argument to parameter list and to call in order to conform to 
>   >     to_xfer_memory field of struct target_ops.
> ?!? I can't see how this can be right.
> 
> >From target.h in the current CVS tree the to_xfer_memory signature looks
> like this:
> 
>     int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr,
>                                    int len, int write,
>                                    struct target_ops * target));

    int (*to_xfer_memory) (CORE_ADDR memaddr, char *myaddr,
                           int len, int write, 
                           struct mem_attrib *attrib,
                           struct target_ops *target);

I think it is an obvious fix - I just need to cross check the change
with another target.  I was hopeing J.T. would get to it before I did.

	Andrew