From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: law@redhat.com, GDB Patches Subject: Re: gdb-patches Digest 11 Feb 2001 23:49:53 -0000 Issue 545 Date: Fri, 16 Feb 2001 10:59:00 -0000 Message-id: <3A8D777D.6730FE39@cygnus.com> References: <6986.982345742@slagheap.cygnus.com> X-SW-Source: 2001-02/msg00304.html Jeffrey A Law wrote: > > 2001-02-11 Paul Hilfinger > > > > * hpux-thread.c (save_inferior_pid): Change call to make_cleanup > > to make arguments conform. > > (restore_inferior_pid): Change signature to that expected by > > make_cleanup. > No comment on this one -- I'm not that familiar with the new guidelines > for make_cleanup. I'll let Andrew comment on this. It was rejected. It was hiding a type compatibility problem by simply casting it. > > 2001-02-11 Paul Hilfinger > > > > * hpux-thread.c (hpux_thread_xfer_memory): Add mem_attrib > > argument to parameter list and to call in order to conform to > > to_xfer_memory field of struct target_ops. > ?!? I can't see how this can be right. > > >From target.h in the current CVS tree the to_xfer_memory signature looks > like this: > > int (*to_xfer_memory) PARAMS ((CORE_ADDR memaddr, char *myaddr, > int len, int write, > struct target_ops * target)); int (*to_xfer_memory) (CORE_ADDR memaddr, char *myaddr, int len, int write, struct mem_attrib *attrib, struct target_ops *target); I think it is an obvious fix - I just need to cross check the change with another target. I was hopeing J.T. would get to it before I did. Andrew