* [PATCH, RFA]: Revamp NaN detection & discussion
@ 2001-01-25 13:03 Mark Kettenis
2001-03-21 6:40 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Mark Kettenis @ 2001-01-25 13:03 UTC (permalink / raw)
To: gdb-patches; +Cc: gdb, taylor
Hi,
In an attempt to get rid of the Linux-specific TARGET_ANALYZE_FLOATING
macro I revamped the code that detects and prints NaN's in
valprint.c:print_floating(). The new code uses the "floatformat.h"
information already present in GDB/libiberty, which means that in
principle all targets that correctly set TARGET_LONG_DOUBLE_FORMAT get
NaN detection for free.
I also changed the way NaN's are printed to something that conforms to
the ISO C99, which means that instead of say
-NaN(0x4000)
GDB now prints
-nan(0x4000)
I think the new format is prettier :-) and it matches what glibc's
printf() will do (although in that case you won't get the sign and the
mantissa in hex). But if people on the list think this could cause
problems, it wouldn't be a problem to change it back to the old
format.
While working on this code I realized that the IEEE_FLOAT target macro
is almost redundant. If only we wouldn't default TARGET_FLOAT_FORMAT
and TARGET_DOUBLE_FORMAT to IEEE formats, we could get rid of it.
Any bright idea's on how to accomplish this?
I also have an itch about floatformat.{ch} and its functions. I'd
rather put all floatformat_* functions in there rather than in
defs.h/utils.c. But since it's part of libiberty that's a bit of a
pain. Is this stuff really used anywhere outside GDB? If not,
perhaps we could claim it back. Otherwise I'd like to add a
gdb_floatformat.{ch} and put all the floatformat stuff there.
Mark
2001-01-25 Mark Kettenis <kettenis@gnu.org>
* defs.h: Provide prototypes for floatformat_is_negative,
floatformat_is_nan and floatformat_mantissa.
* utils.c: Include "gdb_assert.h".
(floatformat_is_negative): New function.
(floatformat_is_nan): New function.
(floatformat_mantissa): New function.
* valprint.c: Include "floatformat.h".
(print_floating): Get rid of the Linux-specific
TARGET_ANALYZE_FLOATING macro and rewrite NaN detection with the
help these new functions. Print NaN's in a format conforming to
ISO C99.
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.34
diff -u -p -r1.34 defs.h
--- defs.h 2001/01/19 08:01:46 1.34
+++ defs.h 2001/01/25 20:38:59
@@ -1,6 +1,6 @@
/* *INDENT-OFF* */ /* ATTR_FORMAT confuses indent, avoid running it for now */
/* Basic, host-specific, and target-specific definitions for GDB.
- Copyright (C) 1986, 1989, 1991-1996, 1998-2000
+ Copyright (C) 1986, 1989, 1991-1996, 1998-2000, 2001
Free Software Foundation, Inc.
This file is part of GDB.
@@ -1121,8 +1121,12 @@ extern void floatformat_to_doublest (con
char *, DOUBLEST *);
extern void floatformat_from_doublest (const struct floatformat *,
DOUBLEST *, char *);
-extern DOUBLEST extract_floating (void *, int);
+extern int floatformat_is_negative (const struct floatformat *, char *);
+extern int floatformat_is_nan (const struct floatformat *, char *);
+extern char *floatformat_mantissa (const struct floatformat *, char *);
+
+extern DOUBLEST extract_floating (void *, int);
extern void store_floating (void *, int, DOUBLEST);
\f
/* On some machines there are bits in addresses which are not really
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.25
diff -u -p -r1.25 utils.c
--- utils.c 2000/12/15 01:01:50 1.25
+++ utils.c 2001/01/25 20:39:02
@@ -1,5 +1,5 @@
/* General utility routines for GDB, the GNU debugger.
- Copyright 1986, 1989, 1990-1992, 1995, 1996, 1998, 2000
+ Copyright 1986, 1989, 1990-1992, 1995, 1996, 1998, 2000, 2001
Free Software Foundation, Inc.
This file is part of GDB.
@@ -20,6 +20,7 @@
Boston, MA 02111-1307, USA. */
#include "defs.h"
+#include "gdb_assert.h"
#include <ctype.h>
#include "gdb_string.h"
#include "event-top.h"
@@ -2729,6 +2730,106 @@ floatformat_from_doublest (CONST struct
*swaphigh++ = tmp;
}
}
+}
+
+/* Check if VAL (which is assumed to be a floating point number whose
+ format is described by FMT) is negative. */
+
+int
+floatformat_is_negative (const struct floatformat *fmt, char *val)
+{
+ unsigned char *uval = (unsigned char *) val;
+
+ return get_field (uval, fmt->byteorder, fmt->totalsize, fmt->sign_start, 1);
+}
+
+/* Check if VAL is "not a number" (NaN) for FMT. */
+
+int
+floatformat_is_nan (const struct floatformat *fmt, char *val)
+{
+ unsigned char *uval = (unsigned char *) val;
+ long exponent;
+ unsigned long mant;
+ unsigned int mant_bits, mant_off;
+ int mant_bits_left;
+
+ if (! fmt->exp_nan)
+ return 0;
+
+ exponent = get_field (uval, fmt->byteorder, fmt->totalsize,
+ fmt->exp_start, fmt->exp_len);
+
+ if (exponent != fmt->exp_nan)
+ return 0;
+
+ mant_bits_left = fmt->man_len;
+ mant_off = fmt->man_start;
+
+ while (mant_bits_left > 0)
+ {
+ mant_bits = min (mant_bits_left, 32);
+
+ mant = get_field (uval, fmt->byteorder, fmt->totalsize,
+ mant_off, mant_bits);
+
+ /* If there is an explicit integer bit, mask it off. */
+ if (mant_off == fmt->man_start
+ && fmt->intbit == floatformat_intbit_yes)
+ mant &= ~(1 << (mant_bits - 1));
+
+ if (mant)
+ return 1;
+
+ mant_off += mant_bits;
+ mant_bits_left -= mant_bits;
+ }
+
+ return 0;
+}
+
+/* Convert the mantissa of VAL (which is assumed to be a floating
+ point number whose format is described by FMT) into a hexadecimal
+ and store it in a static string. Return a pointer to that string. */
+
+char *
+floatformat_mantissa (const struct floatformat *fmt, char *val)
+{
+ unsigned char *uval = (unsigned char *) val;
+ unsigned long mant;
+ unsigned int mant_bits, mant_off;
+ int mant_bits_left;
+ static char res[50];
+ char buf[9];
+
+ /* Make sure we have enough room to store the mantissa. */
+ gdb_assert (sizeof res > ((fmt->man_len + 7) / 8) * 2);
+
+ mant_off = fmt->man_start;
+ mant_bits_left = fmt->man_len;
+ mant_bits = (mant_bits_left % 32) > 0 ? mant_bits_left % 32 : 32;
+
+ mant = get_field (uval, fmt->byteorder, fmt->totalsize,
+ mant_off, mant_bits);
+
+ sprintf (res, "%lx", mant);
+
+ mant_off += mant_bits;
+ mant_bits_left -= mant_bits;
+
+ while (mant_bits_left > 0)
+ {
+ mant = get_field (uval, fmt->byteorder, fmt->totalsize,
+ mant_off, 32);
+
+ sprintf (buf, "%08lx", mant);
+ strcat (res, buf);
+
+ mant_off += 32;
+ mant_bits_left -= 32;
+ }
+
+ return res;
}
/* print routines to handle variable size regs, etc. */
Index: valprint.c
===================================================================
RCS file: /cvs/src/src/gdb/valprint.c,v
retrieving revision 1.9
diff -u -p -r1.9 valprint.c
--- valprint.c 2000/12/15 01:01:50 1.9
+++ valprint.c 2001/01/25 20:39:03
@@ -1,5 +1,5 @@
/* Print values for GDB, the GNU debugger.
- Copyright 1986, 1988, 1989, 1991-1994, 1998, 2000
+ Copyright 1986, 1988, 1989, 1991-1994, 1998, 2000, 2001
Free Software Foundation, Inc.
This file is part of GDB.
@@ -32,6 +32,7 @@
#include "demangle.h"
#include "annotate.h"
#include "valprint.h"
+#include "floatformat.h"
#include <errno.h>
@@ -538,92 +539,39 @@ longest_to_int (LONGEST arg)
return (rtnval);
}
+/* Print a floating point value of type TYPE, pointed to in GDB by
+ VALADDR, on STREAM. */
-/* Print a floating point value of type TYPE, pointed to in GDB by VALADDR,
- on STREAM. */
-
void
print_floating (char *valaddr, struct type *type, struct ui_file *stream)
{
DOUBLEST doub;
int inv;
+ const struct floatformat *fmt = &floatformat_unknown;
unsigned len = TYPE_LENGTH (type);
-
- /* Check for NaN's. Note that this code does not depend on us being
- on an IEEE conforming system. It only depends on the target
- machine using IEEE representation. This means (a)
- cross-debugging works right, and (2) IEEE_FLOAT can (and should)
- be non-zero for systems like the 68881, which uses IEEE
- representation, but is not IEEE conforming. */
- if (IEEE_FLOAT)
- {
- unsigned long low, high;
- /* Is the sign bit 0? */
- int nonnegative;
- /* Is it is a NaN (i.e. the exponent is all ones and
- the fraction is nonzero)? */
- int is_nan;
-
- /* For lint, initialize these two variables to suppress warning: */
- low = high = nonnegative = 0;
- if (len == 4)
- {
- /* It's single precision. */
- /* Assume that floating point byte order is the same as
- integer byte order. */
- low = extract_unsigned_integer (valaddr, 4);
- nonnegative = ((low & 0x80000000) == 0);
- is_nan = ((((low >> 23) & 0xFF) == 0xFF)
- && 0 != (low & 0x7FFFFF));
- low &= 0x7fffff;
- high = 0;
- }
- else if (len == 8)
- {
- /* It's double precision. Get the high and low words. */
- /* Assume that floating point byte order is the same as
- integer byte order. */
- if (TARGET_BYTE_ORDER == BIG_ENDIAN)
- {
- low = extract_unsigned_integer (valaddr + 4, 4);
- high = extract_unsigned_integer (valaddr, 4);
- }
- else
- {
- low = extract_unsigned_integer (valaddr, 4);
- high = extract_unsigned_integer (valaddr + 4, 4);
- }
- nonnegative = ((high & 0x80000000) == 0);
- is_nan = (((high >> 20) & 0x7ff) == 0x7ff
- && !((((high & 0xfffff) == 0)) && (low == 0)));
- high &= 0xfffff;
- }
- else
- {
-#ifdef TARGET_ANALYZE_FLOATING
- TARGET_ANALYZE_FLOATING;
-#else
- /* Extended. We can't detect extended NaNs for this target.
- Also note that currently extendeds get nuked to double in
- REGISTER_CONVERTIBLE. */
- is_nan = 0;
-#endif
- }
-
- if (is_nan)
- {
- /* The meaning of the sign and fraction is not defined by IEEE.
- But the user might know what they mean. For example, they
- (in an implementation-defined manner) distinguish between
- signaling and quiet NaN's. */
- if (high)
- fprintf_filtered (stream, "-NaN(0x%lx%.8lx)" + !!nonnegative,
- high, low);
- else
- fprintf_filtered (stream, "-NaN(0x%lx)" + nonnegative, low);
- return;
- }
+ /* FIXME: kettenis/2001-01-20: The check for IEEE_FLOAT is probably
+ still necessary since GDB by default assumes that the target uses
+ the IEEE 754 representation for its floats and doubles. Of
+ course this is all crock and should be cleaned up. */
+
+ if (len == TARGET_FLOAT_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
+ fmt = TARGET_FLOAT_FORMAT;
+ else if (len == TARGET_DOUBLE_BIT / TARGET_CHAR_BIT && IEEE_FLOAT)
+ fmt = TARGET_DOUBLE_FORMAT;
+ else if (len == TARGET_LONG_DOUBLE_BIT / TARGET_CHAR_BIT)
+ fmt = TARGET_LONG_DOUBLE_FORMAT;
+
+ if (floatformat_is_nan (fmt, valaddr))
+ {
+ if (floatformat_is_negative (fmt, valaddr))
+ fprintf_filtered (stream, "-");
+ fprintf_filtered (stream, "nan(");
+ fprintf_filtered (stream, local_hex_format_prefix ());
+ fprintf_filtered (stream, floatformat_mantissa (fmt, valaddr));
+ fprintf_filtered (stream, local_hex_format_suffix ());
+ fprintf_filtered (stream, ")");
+ return;
}
doub = unpack_double (type, valaddr, &inv);
@@ -633,6 +581,9 @@ print_floating (char *valaddr, struct ty
return;
}
+ /* FIXME: kettenis/2001-01-20: The following code makes too much
+ assumptions about the host and target floating point format. */
+
if (len < sizeof (double))
fprintf_filtered (stream, "%.9g", (double) doub);
else if (len == sizeof (double))
@@ -641,7 +592,8 @@ print_floating (char *valaddr, struct ty
#ifdef PRINTF_HAS_LONG_DOUBLE
fprintf_filtered (stream, "%.35Lg", doub);
#else
- /* This at least wins with values that are representable as doubles */
+ /* This at least wins with values that are representable as
+ doubles. */
fprintf_filtered (stream, "%.17g", (double) doub);
#endif
}
From dhoward@cygnus.com Thu Jan 25 14:22:00 2001
From: Don Howard <dhoward@cygnus.com>
To: gdb-patches@sourceware.cygnus.com
Subject: Re: Patch: grep ^func
Date: Thu, 25 Jan 2001 14:22:00 -0000
Message-id: <Pine.SOL.3.91.1010125142123.14868E-100000@taarna.cygnus.com>
X-SW-Source: 2001-01/msg00285.html
Content-length: 44433
Here is a simple patch that cleans up function declarations/definitions
so that grep ^func will turn up only the function definition.
2001-01-25 Don Howard <dhoward@redhat.com>
* ch-lang.h: Whitespace fixes so that function names appear at the
very start of a line. This is so that ``grep ^func'' works.
* config/alpha/tm-alpha.h: ""
* config/pa/tm-hppa.h: ""
* config/sparc/tm-sp64.h: ""
* config/sparc/tm-sparc.h: ""
* dwarfread.c: ""
* gdbtypes.h: ""
* go32-nat.c: ""
* i386-stub.c: ""
* i386v-nat.c: ""
* language.h: ""
* m68k-stub.c: ""
* mdebugread.c: ""
* minsyms.c: ""
* mips-tdep.c: ""
* monitor.h: ""
* parse.c: ""
* proc-utils.h: ""
* rs6000-nat.c: ""
* sh-stub.c: ""
* somread.c: ""
* somsolib.h: ""
* stabsread.c: ""
* symfile.h: ""
* symtab.h: ""
* target.c: ""
* target.h: ""
* value.h: ""
* xcoffread.c: ""
Index: ch-lang.h
===================================================================
RCS file: /cvs/src/src/gdb/ch-lang.h,v
retrieving revision 1.2
diff -p -u -w -r1.2 ch-lang.h
--- ch-lang.h 2000/05/28 01:12:26 1.2
+++ ch-lang.h 2001/01/25 20:55:18
@@ -1,5 +1,5 @@
/* Chill language support definitions for GDB, the GNU debugger.
- Copyright 1992, 2000 Free Software Foundation, Inc.
+ Copyright 1992, 2000, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -36,5 +36,4 @@ extern int chill_val_print (struct type
extern int chill_value_print (struct value *, struct ui_file *,
int, enum val_prettyprint);
-extern LONGEST
-type_lower_upper (enum exp_opcode, struct type *, struct type **);
+extern LONGEST type_lower_upper (enum exp_opcode, struct type *, struct type **);
Index: dwarfread.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarfread.c,v
retrieving revision 1.6
diff -p -u -w -r1.6 dwarfread.c
--- dwarfread.c 2001/01/19 14:53:44 1.6
+++ dwarfread.c 2001/01/25 20:55:25
@@ -1,5 +1,5 @@
/* DWARF debugging format support for GDB.
- Copyright (C) 1991, 1992, 1993, 1994, 1995, 1996, 1998
+ Copyright (C) 1991, 1992, 1993, 1994, 1995, 1996, 1998, 2001
Free Software Foundation, Inc.
Written by Fred Fish at Cygnus Support. Portions based on dbxread.c,
mipsread.c, coffread.c, and dwarfread.c from a Data General SVR4 gdb port.
@@ -455,19 +455,15 @@ static void add_enum_psymbol (struct die
static void handle_producer (char *);
-static void
-read_file_scope (struct dieinfo *, char *, char *, struct objfile *);
+static void read_file_scope (struct dieinfo *, char *, char *, struct objfile *);
-static void
-read_func_scope (struct dieinfo *, char *, char *, struct objfile *);
+static void read_func_scope (struct dieinfo *, char *, char *, struct objfile *);
-static void
-read_lexical_block_scope (struct dieinfo *, char *, char *, struct objfile *);
+static void read_lexical_block_scope (struct dieinfo *, char *, char *, struct objfile *);
static void scan_partial_symbols (char *, char *, struct objfile *);
-static void
-scan_compilation_units (char *, char *, file_ptr, file_ptr, struct objfile *);
+static void scan_compilation_units (char *, char *, file_ptr, file_ptr, struct objfile *);
static void add_partial_symbol (struct dieinfo *, struct objfile *);
@@ -483,8 +479,7 @@ static void read_ofile_symtab (struct pa
static void process_dies (char *, char *, struct objfile *);
-static void
-read_structure_scope (struct dieinfo *, char *, char *, struct objfile *);
+static void read_structure_scope (struct dieinfo *, char *, char *, struct objfile *);
static struct type *decode_array_element_type (char *);
@@ -498,8 +493,7 @@ static void read_tag_string_type (struct
static void read_subroutine_type (struct dieinfo *, char *, char *);
-static void
-read_enumeration (struct dieinfo *, char *, char *, struct objfile *);
+static void read_enumeration (struct dieinfo *, char *, char *, struct objfile *);
static struct type *struct_type (struct dieinfo *, char *, char *,
struct objfile *);
@@ -526,8 +520,7 @@ static struct type *alloc_utype (DIE_REF
static struct symbol *new_symbol (struct dieinfo *, struct objfile *);
-static void
-synthesize_typedef (struct dieinfo *, struct objfile *, struct type *);
+static void synthesize_typedef (struct dieinfo *, struct objfile *, struct type *);
static int locval (struct dieinfo *);
Index: gdbtypes.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.h,v
retrieving revision 1.6
diff -p -u -w -r1.6 gdbtypes.h
--- gdbtypes.h 2000/09/02 00:05:43 1.6
+++ gdbtypes.h 2001/01/25 20:55:28
@@ -1,6 +1,7 @@
/* Internal type definitions for GDB.
- Copyright (C) 1992-1994, 1996, 1998-2000 Free Software Foundation, Inc.
- Contributed by Cygnus Support, using pieces from other GDB modules.
+ Copyright (C) 1992-1994, 1996, 1998, 1999, 2000 Free Software
+ Foundation, Inc. Contributed by Cygnus Support, using pieces from
+ other GDB modules.
This file is part of GDB.
@@ -958,12 +959,10 @@ extern struct type *make_cv_type (int, i
extern struct type *lookup_member_type (struct type *, struct type *);
-extern void
-smash_to_method_type (struct type *, struct type *, struct type *,
+extern void smash_to_method_type (struct type *, struct type *, struct type *,
struct type **);
-extern void
-smash_to_member_type (struct type *, struct type *, struct type *);
+extern void smash_to_member_type (struct type *, struct type *, struct type *);
extern struct type *allocate_stub_method (struct type *);
Index: go32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/go32-nat.c,v
retrieving revision 1.6
diff -p -u -w -r1.6 go32-nat.c
--- go32-nat.c 2000/08/06 07:19:38 1.6
+++ go32-nat.c 2001/01/25 20:55:29
@@ -1,6 +1,6 @@
/* Native debugging support for Intel x86 running DJGPP.
- Copyright 1997, 1999 Free Software Foundation, Inc.
- Written by Robert Hoehne.
+ Copyright 1997, 1999, 2001 Free Software Foundation, Inc. Written
+ by Robert Hoehne.
This file is part of GDB.
@@ -118,20 +118,31 @@ typedef struct {
int redirected;
} cmdline_t;
-void redir_cmdline_delete (cmdline_t *ptr) {ptr->redirected = 0;}
-int redir_cmdline_parse (const char *args, cmdline_t *ptr)
+void
+redir_cmdline_delete (cmdline_t *ptr)
{
+ ptr->redirected = 0;
+}
+int
+redir_cmdline_parse (const char *args, cmdline_t *ptr)
+{
return -1;
}
-int redir_to_child (cmdline_t *ptr)
+int
+redir_to_child (cmdline_t *ptr)
{
return 1;
}
-int redir_to_debugger (cmdline_t *ptr)
+int
+redir_to_debugger (cmdline_t *ptr)
{
return 1;
+}
+int
+redir_debug_init (cmdline_t *ptr)
+{
+ return 0;
}
-int redir_debug_init (cmdline_t *ptr) { return 0; }
#endif /* __DJGPP_MINOR < 3 */
extern void _initialize_go32_nat (void);
Index: i386-stub.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-stub.c,v
retrieving revision 1.3
diff -p -u -w -r1.3 i386-stub.c
Index: i386v-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386v-nat.c,v
retrieving revision 1.7
diff -p -u -w -r1.7 i386v-nat.c
--- i386v-nat.c 2000/07/30 01:48:25 1.7
+++ i386v-nat.c 2001/01/25 20:55:30
@@ -1,5 +1,6 @@
-/* Intel 386 native support for SYSV systems (pre-SVR4).
- Copyright (C) 1988, 89, 91, 92, 94, 96, 1998 Free Software Foundation, Inc.
+/* Intel 386 native support for SYSV systems (pre-SVR4). Copyright
+ (C) 1988, 89, 91, 92, 94, 96, 1998, 2001 Free Software Foundation,
+ Inc.
This file is part of GDB.
@@ -131,11 +132,9 @@ static int debug_control_mirror;
/* Record which address associates with which register. */
static CORE_ADDR address_lookup[DR_LASTADDR - DR_FIRSTADDR + 1];
-static int
-i386_insert_aligned_watchpoint (int, CORE_ADDR, CORE_ADDR, int, int);
+static int i386_insert_aligned_watchpoint (int, CORE_ADDR, CORE_ADDR, int, int);
-static int
-i386_insert_nonaligned_watchpoint (int, CORE_ADDR, CORE_ADDR, int, int);
+static int i386_insert_nonaligned_watchpoint (int, CORE_ADDR, CORE_ADDR, int, int);
/* Insert a watchpoint. */
Index: language.c
===================================================================
RCS file: /cvs/src/src/gdb/language.c,v
retrieving revision 1.11
diff -p -u -w -r1.11 language.c
--- language.c 2000/12/15 01:01:47 1.11
+++ language.c 2001/01/25 20:55:31
@@ -1,7 +1,7 @@
/* Multiple source language support for GDB.
- Copyright 1991, 1992, 2000 Free Software Foundation, Inc.
- Contributed by the Department of Computer Science at the State University
- of New York at Buffalo.
+ Copyright 1991, 1992, 2000, 2001 Free Software Foundation, Inc.
+ Contributed by the Department of Computer Science at the State
+ University of New York at Buffalo.
This file is part of GDB.
Index: language.h
===================================================================
RCS file: /cvs/src/src/gdb/language.h,v
retrieving revision 1.7
diff -p -u -w -r1.7 language.h
--- language.h 2000/10/27 15:02:42 1.7
+++ language.h 2001/01/25 20:55:32
@@ -1,7 +1,7 @@
/* Source-language-related definitions for GDB.
- Copyright 1991, 1992, 2000 Free Software Foundation, Inc.
- Contributed by the Department of Computer Science at the State University
- of New York at Buffalo.
+ Copyright 1991, 1992, 2000, 2001 Free Software Foundation, Inc.
+ Contributed by the Department of Computer Science at the State
+ University of New York at Buffalo.
This file is part of GDB.
@@ -441,9 +441,7 @@ extern void op_error (char *fmt, enum ex
extern void type_error (char *, ...) ATTR_FORMAT (printf, 1, 2);
-void
-range_error (char *, ...)
-ATTR_FORMAT (printf, 1, 2);
+void range_error (char *, ...) ATTR_FORMAT (printf, 1, 2);
/* Data: Does this value represent "truth" to the current language? */
Index: m68k-stub.c
===================================================================
RCS file: /cvs/src/src/gdb/m68k-stub.c,v
retrieving revision 1.3
diff -p -u -w -r1.3 m68k-stub.c
--- m68k-stub.c 2001/01/23 19:45:08 1.3
+++ m68k-stub.c 2001/01/25 20:55:32
@@ -125,8 +125,7 @@ extern ExceptionHook exceptionHook; /*
/************************/
/* FORWARD DECLARATIONS */
/************************/
-static void
-initializeRemcomErrorFrame ();
+static void initializeRemcomErrorFrame ();
/************************************************************************/
/* BUFMAX defines the maximum number of characters in inbound/outbound buffers*/
Index: mdebugread.c
===================================================================
RCS file: /cvs/src/src/gdb/mdebugread.c,v
retrieving revision 1.9
diff -p -u -w -r1.9 mdebugread.c
--- mdebugread.c 2000/12/15 01:01:48 1.9
+++ mdebugread.c 2001/01/25 20:55:35
@@ -1,9 +1,9 @@
/* Read a symbol table in ECOFF format (Third-Eye).
- Copyright 1986, 87, 89, 90, 91, 92, 93, 94, 95, 96, 97, 1998
- Free Software Foundation, Inc.
- Original version contributed by Alessandro Forin (af@cs.cmu.edu) at
- CMU. Major work by Per Bothner, John Gilmore and Ian Lance Taylor
- at Cygnus Support.
+ Copyright 1986, 1987, 1989, 1990, 1991, 1992, 1993, 1994, 1995,
+ 1996, 1997, 1998, 2001 Free Software Foundation, Inc. Original
+ version contributed by Alessandro Forin (af@cs.cmu.edu) at CMU.
+ Major work by Per Bothner, John Gilmore and Ian Lance Taylor at
+ Cygnus Support.
This file is part of GDB.
@@ -338,8 +338,7 @@ static char *fdr_name (FDR *);
static void mdebug_psymtab_to_symtab (struct partial_symtab *);
-static int
-upgrade_type (int, struct type **, int, union aux_ext *, int, char *);
+static int upgrade_type (int, struct type **, int, union aux_ext *, int, char *);
static void parse_partial_symbols (struct objfile *);
@@ -347,8 +346,7 @@ static FDR * get_rfd (int, int);
static int has_opaque_xref (FDR *, SYMR *);
-static int
-cross_ref (int, union aux_ext *, struct type **, enum type_code,
+static int cross_ref (int, union aux_ext *, struct type **, enum type_code,
char **, int, char *);
static struct symbol *new_symbol (char *);
@@ -363,8 +361,7 @@ static struct linetable *new_linetable (
static struct blockvector *new_bvect (int);
-static int
-parse_symbol (SYMR *, union aux_ext *, char *, int, struct section_offsets *,
+static int parse_symbol (SYMR *, union aux_ext *, char *, int, struct section_offsets *,
struct objfile *);
static struct type *parse_type (int, union aux_ext *, unsigned int, int *,
@@ -393,8 +390,7 @@ static int add_line (struct linetable *,
static struct linetable *shrink_linetable (struct linetable *);
-static void
-handle_psymbol_enumerators (struct objfile *, FDR *, int, CORE_ADDR);
+static void handle_psymbol_enumerators (struct objfile *, FDR *, int, CORE_ADDR);
static char *mdebug_next_symbol_text (struct objfile *);
\f
Index: minsyms.c
===================================================================
RCS file: /cvs/src/src/gdb/minsyms.c,v
retrieving revision 1.12
diff -p -u -w -r1.12 minsyms.c
--- minsyms.c 2000/12/15 01:01:48 1.12
+++ minsyms.c 2001/01/25 20:55:36
@@ -1,6 +1,7 @@
/* GDB routines for manipulating the minimal symbol tables.
- Copyright 1992, 93, 94, 96, 97, 1998 Free Software Foundation, Inc.
- Contributed by Cygnus Support, using pieces from other GDB modules.
+ Copyright 1992, 1993, 1994, 1996, 1997, 1998, 2001 Free Software
+ Foundation, Inc. Contributed by Cygnus Support, using pieces from
+ other GDB modules.
This file is part of GDB.
@@ -77,8 +78,7 @@ static int msym_count;
static int compare_minimal_symbols (const void *, const void *);
-static int
-compact_minimal_symbols (struct minimal_symbol *, int, struct objfile *);
+static int compact_minimal_symbols (struct minimal_symbol *, int, struct objfile *);
static void add_minsym_to_demangled_hash_table (struct minimal_symbol *sym,
struct minimal_symbol **table);
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.38
diff -p -u -w -r1.38 mips-tdep.c
--- mips-tdep.c 2001/01/04 23:22:45 1.38
+++ mips-tdep.c 2001/01/25 20:55:43
@@ -1,7 +1,7 @@
/* Target-dependent code for the MIPS architecture, for GDB, the GNU Debugger.
Copyright 1988, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996,
- 1997, 1998, 1999, 2000, Free Software Foundation, Inc.
+ 1997, 1998, 1999, 2000, 2001, Free Software Foundation, Inc.
Contributed by Alessandro Forin(af@cs.cmu.edu) at CMU
and by Per Bothner(bothner@cs.wisc.edu) at U.Wisconsin.
@@ -250,8 +250,7 @@ static void mips_show_processor_type_com
static void reinit_frame_cache_sfunc (char *, int, struct cmd_list_element *);
-static mips_extra_func_info_t
-find_proc_desc (CORE_ADDR pc, struct frame_info *next_frame);
+static mips_extra_func_info_t find_proc_desc (CORE_ADDR pc, struct frame_info *next_frame);
static CORE_ADDR after_prologue (CORE_ADDR pc,
mips_extra_func_info_t proc_desc);
Index: monitor.h
===================================================================
RCS file: /cvs/src/src/gdb/monitor.h,v
retrieving revision 1.5
diff -p -u -w -r1.5 monitor.h
--- monitor.h 2000/11/03 22:00:56 1.5
+++ monitor.h 2001/01/25 20:55:44
@@ -1,6 +1,7 @@
/* Definitions for remote debugging interface for ROM monitors.
- Copyright 1990, 1991, 1992, 1996 Free Software Foundation, Inc.
- Contributed by Cygnus Support. Written by Rob Savoye for Cygnus.
+ Copyright 1990, 1991, 1992, 1996, 20001 Free Software Foundation,
+ Inc. Contributed by Cygnus Support. Written by Rob Savoye for
+ Cygnus.
This file is part of GDB.
@@ -17,8 +18,7 @@
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330,
- Boston, MA 02111-1307, USA.
- */
+ Boston, MA 02111-1307, USA. */
#include "serial.h"
@@ -238,9 +238,7 @@ extern char *monitor_supply_register (in
extern int monitor_expect (char *prompt, char *buf, int buflen);
extern int monitor_expect_prompt (char *buf, int buflen);
extern void monitor_printf (char *, ...) ATTR_FORMAT (printf, 1, 2);
-extern void
-monitor_printf_noecho (char *, ...)
-ATTR_FORMAT (printf, 1, 2);
+extern void monitor_printf_noecho (char *, ...) ATTR_FORMAT (printf, 1, 2);
extern void monitor_write (char *buf, int buflen);
extern int monitor_readchar (void);
extern char *monitor_get_dev_name (void);
Index: parse.c
===================================================================
RCS file: /cvs/src/src/gdb/parse.c,v
retrieving revision 1.11
diff -p -u -w -r1.11 parse.c
--- parse.c 2000/12/15 01:01:48 1.11
+++ parse.c 2001/01/25 20:55:47
@@ -1,7 +1,8 @@
/* Parse expressions for GDB.
- Copyright (C) 1986, 89, 90, 91, 94, 98, 1999 Free Software Foundation, Inc.
- Modified from expread.y by the Department of Computer Science at the
- State University of New York at Buffalo, 1991.
+ Copyright (C) 1986, 1989, 1990, 1991, 1994, 1998, 1999, 2001 Free
+ Software Foundation, Inc. Modified from expread.y by the
+ Department of Computer Science at the State University of New York
+ at Buffalo, 1991.
This file is part of GDB.
@@ -85,8 +86,7 @@ static void free_funcalls (void *ignore)
static void prefixify_expression (struct expression *);
-static void
-prefixify_subexp (struct expression *, struct expression *, int, int);
+static void prefixify_subexp (struct expression *, struct expression *, int, int);
void _initialize_parse (void);
Index: proc-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/proc-utils.h,v
retrieving revision 1.3
diff -p -u -w -r1.3 proc-utils.h
--- proc-utils.h 2000/05/07 23:09:45 1.3
+++ proc-utils.h 2001/01/25 20:55:47
@@ -1,5 +1,5 @@
/* Machine independent support for SVR4 /proc (process file system) for GDB.
- Copyright 1999 Free Software Foundation, Inc.
+ Copyright 1999, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -22,44 +22,32 @@ Inc., 59 Temple Place - Suite 330, Bosto
* Pretty-print functions for /proc data
*/
-extern void
-proc_prettyprint_why (unsigned long why, unsigned long what, int verbose);
+extern void proc_prettyprint_why (unsigned long why, unsigned long what, int verbose);
-extern void
-proc_prettyprint_syscalls (sysset_t *sysset, int verbose);
+extern void proc_prettyprint_syscalls (sysset_t *sysset, int verbose);
-extern void
-proc_prettyprint_syscall (int num, int verbose);
+extern void proc_prettyprint_syscall (int num, int verbose);
extern void proc_prettyprint_flags (unsigned long flags, int verbose);
-extern void
-proc_prettyfprint_signalset (FILE *file, sigset_t *sigset, int verbose);
+extern void proc_prettyfprint_signalset (FILE *file, sigset_t *sigset, int verbose);
-extern void
-proc_prettyfprint_faultset (FILE *file, fltset_t *fltset, int verbose);
+extern void proc_prettyfprint_faultset (FILE *file, fltset_t *fltset, int verbose);
-extern void
-proc_prettyfprint_syscall (FILE *file, int num, int verbose);
+extern void proc_prettyfprint_syscall (FILE *file, int num, int verbose);
-extern void
-proc_prettyfprint_signal (FILE *file, int signo, int verbose);
+extern void proc_prettyfprint_signal (FILE *file, int signo, int verbose);
-extern void
-proc_prettyfprint_flags (FILE *file, unsigned long flags, int verbose);
+extern void proc_prettyfprint_flags (FILE *file, unsigned long flags, int verbose);
-extern void
-proc_prettyfprint_why (FILE *file, unsigned long why,
+extern void proc_prettyfprint_why (FILE *file, unsigned long why,
unsigned long what, int verbose);
-extern void
-proc_prettyfprint_fault (FILE *file, int faultno, int verbose);
+extern void proc_prettyfprint_fault (FILE *file, int faultno, int verbose);
-extern void
-proc_prettyfprint_syscalls (FILE *file, sysset_t *sysset, int verbose);
+extern void proc_prettyfprint_syscalls (FILE *file, sysset_t *sysset, int verbose);
-extern void
-proc_prettyfprint_status (long, int, int, int);
+extern void proc_prettyfprint_status (long, int, int, int);
/*
* Trace functions for /proc api.
Index: rs6000-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-nat.c,v
retrieving revision 1.12
diff -p -u -w -r1.12 rs6000-nat.c
--- rs6000-nat.c 2000/12/15 01:01:49 1.12
+++ rs6000-nat.c 2001/01/25 20:55:48
@@ -1,6 +1,6 @@
/* IBM RS/6000 native-dependent code for GDB, the GNU debugger.
- Copyright 1986, 1987, 1989, 1991, 1992, 1994, 1995, 1996, 1997, 1998
- Free Software Foundation, Inc.
+ Copyright 1986, 1987, 1989, 1991, 1992, 1994, 1995, 1996, 1997,
+ 1998, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -138,8 +138,7 @@ static void fetch_core_registers (char *
static void exec_one_dummy_insn (void);
-extern void
-fixup_breakpoints (CORE_ADDR low, CORE_ADDR high, CORE_ADDR delta);
+extern void fixup_breakpoints (CORE_ADDR low, CORE_ADDR high, CORE_ADDR delta);
/* Conversion from gdb-to-system special purpose register numbers. */
Index: sh-stub.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-stub.c,v
retrieving revision 1.2
diff -p -u -w -r1.2 sh-stub.c
--- sh-stub.c 2000/07/30 01:48:27 1.2
+++ sh-stub.c 2001/01/25 20:55:52
@@ -790,7 +790,8 @@ gdb_handle_exception (int exceptionVecto
static int ingdbmode;
/* We've had an exception - choose to go into the monitor or
the gdb stub */
-void handle_exception(int exceptionVector)
+void
+handle_exception(int exceptionVector)
{
#ifdef MONITOR
if (ingdbmode != GDBCOOKIE)
@@ -1148,7 +1149,8 @@ INIT (void)
}
-static void sr()
+static void
+sr()
{
@@ -1217,7 +1219,8 @@ L_hdl_except:
}
-static void rr()
+static void
+rr()
{
asm("
.align 2
@@ -1264,7 +1267,8 @@ restoreRegisters:
}
-static __inline__ void code_for_catch_exception(int n)
+static __inline__ void
+code_for_catch_exception(int n)
{
asm(" .globl _catch_exception_%O0" : : "i" (n) );
asm(" _catch_exception_%O0:" :: "i" (n) );
Index: somread.c
===================================================================
RCS file: /cvs/src/src/gdb/somread.c,v
retrieving revision 1.9
diff -p -u -w -r1.9 somread.c
--- somread.c 2000/12/15 01:01:49 1.9
+++ somread.c 2001/01/25 20:55:53
@@ -1,6 +1,6 @@
/* Read HP PA/Risc object files for GDB.
- Copyright 1991, 1992, 1996, 1999 Free Software Foundation, Inc.
- Written by Fred Fish at Cygnus Support.
+ Copyright 1991, 1992, 1996, 1999, 2001 Free Software Foundation,
+ Inc. Written by Fred Fish at Cygnus Support.
This file is part of GDB.
@@ -44,11 +44,9 @@ static void som_symfile_read (struct obj
static void som_symfile_finish (struct objfile *);
-static void
-som_symtab_read (bfd *, struct objfile *, struct section_offsets *);
+static void som_symtab_read (bfd *, struct objfile *, struct section_offsets *);
-static void
-som_symfile_offsets (struct objfile *, struct section_addr_info *);
+static void som_symfile_offsets (struct objfile *, struct section_addr_info *);
/* FIXME: These should really be in a common header somewhere */
Index: somsolib.h
===================================================================
RCS file: /cvs/src/src/gdb/somsolib.h,v
retrieving revision 1.2
diff -p -u -w -r1.2 somsolib.h
--- somsolib.h 2000/05/28 01:12:29 1.2
+++ somsolib.h 2001/01/25 20:55:53
@@ -1,5 +1,5 @@
/* HP SOM Shared library declarations for GDB, the GNU Debugger.
- Copyright (C) 1992 Free Software Foundation, Inc.
+ Copyright (C) 1992, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -35,8 +35,7 @@ extern void som_solib_add (char *, int,
extern CORE_ADDR som_solib_get_got_by_pc (CORE_ADDR);
-extern int
-som_solib_section_offsets (struct objfile *, struct section_offsets *);
+extern int som_solib_section_offsets (struct objfile *, struct section_offsets *);
/* Function to be called when the inferior starts up, to discover the names
of shared libraries that are dynamically linked, the base addresses to
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.10
diff -p -u -w -r1.10 stabsread.c
--- stabsread.c 2000/12/15 01:01:49 1.10
+++ stabsread.c 2001/01/25 20:56:03
@@ -1,6 +1,6 @@
/* Support routines for decoding "stabs" debugging information format.
- Copyright 1986, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 1998
- Free Software Foundation, Inc.
+ Copyright 1986, 1987, 1988, 1989, 1990, 1991, 1992, 1993, 1994,
+ 1995, 1996, 1997, 1998, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -81,8 +81,7 @@ struct field_info
*fnlist;
};
-static void
-read_one_struct_field (struct field_info *, char **, char *,
+static void read_one_struct_field (struct field_info *, char **, char *,
struct type *, struct objfile *);
static char *get_substring (char **, int);
@@ -93,8 +92,7 @@ static long read_huge_number (char **, i
static struct type *error_type (char **, struct objfile *);
-static void
-patch_block_stabs (struct pending *, struct pending_stabs *,
+static void patch_block_stabs (struct pending *, struct pending_stabs *,
struct objfile *);
static void fix_common_block (struct symbol *, int);
@@ -112,26 +110,21 @@ static struct type *read_enum_type (char
static struct type *rs6000_builtin_type (int);
-static int
-read_member_functions (struct field_info *, char **, struct type *,
+static int read_member_functions (struct field_info *, char **, struct type *,
struct objfile *);
-static int
-read_struct_fields (struct field_info *, char **, struct type *,
+static int read_struct_fields (struct field_info *, char **, struct type *,
struct objfile *);
-static int
-read_baseclasses (struct field_info *, char **, struct type *,
+static int read_baseclasses (struct field_info *, char **, struct type *,
struct objfile *);
-static int
-read_tilde_fields (struct field_info *, char **, struct type *,
+static int read_tilde_fields (struct field_info *, char **, struct type *,
struct objfile *);
static int attach_fn_fields_to_type (struct field_info *, struct type *);
-static int
-attach_fields_to_type (struct field_info *, struct type *, struct objfile *);
+static int attach_fields_to_type (struct field_info *, struct type *, struct objfile *);
static struct type *read_struct_type (char **, struct type *,
struct objfile *);
@@ -141,33 +134,28 @@ static struct type *read_array_type (cha
static struct type **read_args (char **, int, struct objfile *);
-static int
-read_cpp_abbrev (struct field_info *, char **, struct type *,
+static int read_cpp_abbrev (struct field_info *, char **, struct type *,
struct objfile *);
/* new functions added for cfront support */
-static int
-copy_cfront_struct_fields (struct field_info *, struct type *,
+static int copy_cfront_struct_fields (struct field_info *, struct type *,
struct objfile *);
static char *get_cfront_method_physname (char *);
-static int
-read_cfront_baseclasses (struct field_info *, char **,
+static int read_cfront_baseclasses (struct field_info *, char **,
struct type *, struct objfile *);
-static int
-read_cfront_static_fields (struct field_info *, char **,
+static int read_cfront_static_fields (struct field_info *, char **,
struct type *, struct objfile *);
-static int
-read_cfront_member_functions (struct field_info *, char **,
+
+static int read_cfront_member_functions (struct field_info *, char **,
struct type *, struct objfile *);
/* end new functions added for cfront support */
-static void
-add_live_range (struct objfile *, struct symbol *, CORE_ADDR, CORE_ADDR);
+static void add_live_range (struct objfile *, struct symbol *, CORE_ADDR, CORE_ADDR);
static int resolve_live_range (struct objfile *, struct symbol *, char *);
@@ -175,8 +163,7 @@ static int process_reference (char **str
static CORE_ADDR ref_search_value (int refnum);
-static int
-resolve_symbol_reference (struct objfile *, struct symbol *, char *);
+static int resolve_symbol_reference (struct objfile *, struct symbol *, char *);
void stabsread_clear_cache (void);
Index: symfile.h
===================================================================
RCS file: /cvs/src/src/gdb/symfile.h,v
retrieving revision 1.7
diff -p -u -w -r1.7 symfile.h
--- symfile.h 2000/12/05 18:28:25 1.7
+++ symfile.h 2001/01/25 20:56:03
@@ -1,5 +1,5 @@
/* Definitions for reading symbol files into GDB.
- Copyright (C) 1990, 1991, 1992, 1993, 1994, 1996, 2000
+ Copyright (C) 1990, 1991, 1992, 1993, 1994, 1996, 2000, 2001
Free Software Foundation, Inc.
This file is part of GDB.
@@ -131,24 +131,20 @@ struct sym_fns
/* The default version of sym_fns.sym_offsets for readers that don't
do anything special. */
-extern void
-default_symfile_offsets (struct objfile *objfile, struct section_addr_info *);
+extern void default_symfile_offsets (struct objfile *objfile, struct section_addr_info *);
-extern void
-extend_psymbol_list (struct psymbol_allocation_list *, struct objfile *);
+extern void extend_psymbol_list (struct psymbol_allocation_list *, struct objfile *);
/* Add any kind of symbol to a psymbol_allocation_list. */
/* #include "demangle.h" */
-extern void
-add_psymbol_to_list (char *, int, namespace_enum, enum address_class,
+extern void add_psymbol_to_list (char *, int, namespace_enum, enum address_class,
struct psymbol_allocation_list *, long, CORE_ADDR,
enum language, struct objfile *);
-extern void
-add_psymbol_with_dem_name_to_list (char *, int, char *, int, namespace_enum,
+extern void add_psymbol_with_dem_name_to_list (char *, int, char *, int, namespace_enum,
enum address_class,
struct psymbol_allocation_list *,
long, CORE_ADDR,
@@ -169,8 +165,7 @@ extern void add_symtab_fns (struct sym_f
extern void init_entry_point_info (struct objfile *);
-extern void
-syms_from_objfile (struct objfile *, struct section_addr_info *, int, int);
+extern void syms_from_objfile (struct objfile *, struct section_addr_info *, int, int);
extern void new_symfile_objfile (struct objfile *, int, int);
@@ -187,8 +182,7 @@ build_section_addr_info_from_section_tab
/* Free all memory allocated by build_section_addr_info_from_section_table. */
-extern void
-free_section_addr_info (struct section_addr_info *);
+extern void free_section_addr_info (struct section_addr_info *);
extern struct partial_symtab *start_psymtab_common (struct objfile *,
@@ -275,8 +269,7 @@ extern CORE_ADDR symbol_overlayed_addres
/* From dwarfread.c */
-extern void
-dwarf_build_psymtabs (struct objfile *, int, file_ptr, unsigned int,
+extern void dwarf_build_psymtabs (struct objfile *, int, file_ptr, unsigned int,
file_ptr, unsigned int);
/* From dwarf2read.c */
@@ -293,13 +286,11 @@ struct ecoff_debug_hack
struct ecoff_debug_swap *a;
struct ecoff_debug_info *b;
};
-extern void
-mdebug_build_psymtabs (struct objfile *,
+extern void mdebug_build_psymtabs (struct objfile *,
const struct ecoff_debug_swap *,
struct ecoff_debug_info *);
-extern void
-elfmdebug_build_psymtabs (struct objfile *,
+extern void elfmdebug_build_psymtabs (struct objfile *,
const struct ecoff_debug_swap *, asection *);
#endif /* !defined(SYMFILE_H) */
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.16
diff -p -u -w -r1.16 symtab.h
--- symtab.h 2000/11/10 23:02:56 1.16
+++ symtab.h 2001/01/25 20:56:05
@@ -1,6 +1,6 @@
/* Symbol table definitions for GDB.
- Copyright 1986, 89, 91, 92, 93, 94, 95, 96, 1998
- Free Software Foundation, Inc.
+ Copyright 1986, 1989, 1991, 1992, 1993, 1994, 1995, 1996, 1998,
+ 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -1131,13 +1131,11 @@ extern struct symbol *find_pc_sect_funct
/* lookup function from address, return name, start addr and end addr */
-extern int
-find_pc_partial_function (CORE_ADDR, char **, CORE_ADDR *, CORE_ADDR *);
+extern int find_pc_partial_function (CORE_ADDR, char **, CORE_ADDR *, CORE_ADDR *);
extern void clear_pc_function_cache (void);
-extern int
-find_pc_sect_partial_function (CORE_ADDR, asection *,
+extern int find_pc_sect_partial_function (CORE_ADDR, asection *,
char **, CORE_ADDR *, CORE_ADDR *);
/* from symtab.c: */
@@ -1211,8 +1209,7 @@ extern unsigned int msymbol_hash_iw (con
extern unsigned int msymbol_hash (const char *);
-extern void
-add_minsym_to_hash_table (struct minimal_symbol *sym,
+extern void add_minsym_to_hash_table (struct minimal_symbol *sym,
struct minimal_symbol **table);
extern struct minimal_symbol *lookup_minimal_symbol (const char *,
@@ -1234,8 +1231,7 @@ extern struct minimal_symbol *lookup_min
asection
*);
-extern struct minimal_symbol
- *lookup_solib_trampoline_symbol_by_pc (CORE_ADDR);
+extern struct minimal_symbol *lookup_solib_trampoline_symbol_by_pc (CORE_ADDR);
extern CORE_ADDR find_solib_trampoline_target (CORE_ADDR);
@@ -1333,8 +1329,7 @@ extern struct symbol *find_addr_symbol (
extern int find_line_pc (struct symtab *, int, CORE_ADDR *);
-extern int
-find_line_pc_range (struct symtab_and_line, CORE_ADDR *, CORE_ADDR *);
+extern int find_line_pc_range (struct symtab_and_line, CORE_ADDR *, CORE_ADDR *);
extern void resolve_sal_pc (struct symtab_and_line *);
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.18
diff -p -u -w -r1.18 target.c
--- target.c 2001/01/23 22:48:56 1.18
+++ target.c 2001/01/25 20:56:08
@@ -78,8 +78,7 @@ static void normal_target_post_startup_i
partial transfers, try either target_read_memory_partial or
target_write_memory_partial). */
-static int
-target_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write);
+static int target_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write);
static void init_dummy_target (void);
@@ -101,8 +100,7 @@ static void debug_to_store_registers (in
static void debug_to_prepare_to_store (void);
-static int
-debug_to_xfer_memory (CORE_ADDR, char *, int, int, struct mem_attrib *,
+static int debug_to_xfer_memory (CORE_ADDR, char *, int, int, struct mem_attrib *,
struct target_ops *);
static void debug_to_files_info (struct target_ops *);
Index: target.h
===================================================================
RCS file: /cvs/src/src/gdb/target.h,v
retrieving revision 1.11
diff -p -u -w -r1.11 target.h
--- target.h 2001/01/23 22:48:56 1.11
+++ target.h 2001/01/25 20:56:10
@@ -643,11 +643,9 @@ extern int child_xfer_memory (CORE_ADDR,
of bytes actually transfered is not defined) and ERR is set to a
non-zero error indication. */
-extern int
-target_read_memory_partial (CORE_ADDR addr, char *buf, int len, int *err);
+extern int target_read_memory_partial (CORE_ADDR addr, char *buf, int len, int *err);
-extern int
-target_write_memory_partial (CORE_ADDR addr, char *buf, int len, int *err);
+extern int target_write_memory_partial (CORE_ADDR addr, char *buf, int len, int *err);
extern char *child_pid_to_exec_file (int);
@@ -1302,8 +1300,7 @@ struct section_table
/* Builds a section table, given args BFD, SECTABLE_PTR, SECEND_PTR.
Returns 0 if OK, 1 on error. */
-extern int
-build_section_table (bfd *, struct section_table **, struct section_table **);
+extern int build_section_table (bfd *, struct section_table **, struct section_table **);
/* From mem-break.c */
@@ -1340,8 +1337,7 @@ extern struct target_ops *find_core_targ
extern struct target_ops *find_target_beneath (struct target_ops *);
-extern int
-target_resize_to_sections (struct target_ops *target, int num_added);
+extern int target_resize_to_sections (struct target_ops *target, int num_added);
extern void remove_target_sections (bfd *abfd);
Index: value.h
===================================================================
RCS file: /cvs/src/src/gdb/value.h,v
retrieving revision 1.13
diff -p -u -w -r1.13 value.h
--- value.h 2001/01/09 00:12:48 1.13
+++ value.h 2001/01/25 20:56:12
@@ -1,5 +1,5 @@
-/* Definitions for values of C expressions, for GDB.
- Copyright 1986, 1987, 1989, 1992-1996, 2000 Free Software Foundation, Inc.
+/* Definitions for values of C expressions, for GDB. Copyright 1986,
+ 1987, 1989, 1992-1996, 2000-2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -503,8 +503,7 @@ extern void get_saved_register (char *ra
struct frame_info *frame,
int regnum, enum lval_type *lval);
-extern void
-modify_field (char *addr, LONGEST fieldval, int bitpos, int bitsize);
+extern void modify_field (char *addr, LONGEST fieldval, int bitpos, int bitsize);
extern void type_print (struct type * type, char *varstring,
struct ui_file * stream, int show);
Index: xcoffread.c
===================================================================
RCS file: /cvs/src/src/gdb/xcoffread.c,v
retrieving revision 1.11
diff -p -u -w -r1.11 xcoffread.c
--- xcoffread.c 2000/12/15 01:01:51 1.11
+++ xcoffread.c 2001/01/25 20:56:17
@@ -1,8 +1,8 @@
/* Read AIX xcoff symbol tables and convert to internal format, for GDB.
- Copyright 1986, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 1997
- Free Software Foundation, Inc.
- Derived from coffread.c, dbxread.c, and a lot of hacking.
- Contributed by IBM Corporation.
+ Copyright 1986, 1987, 1988, 1989, 1990, 1991, 1992, 1993, 1994,
+ 1995, 1996, 1997, 2001 Free Software Foundation, Inc. Derived from
+ coffread.c, dbxread.c, and a lot of hacking. Contributed by IBM
+ Corporation.
This file is part of GDB.
@@ -203,8 +203,7 @@ static char *xcoff_next_symbol_text (str
static void record_include_begin (struct coff_symbol *);
-static void
-enter_line_range (struct subfile *, unsigned, unsigned,
+static void enter_line_range (struct subfile *, unsigned, unsigned,
CORE_ADDR, CORE_ADDR, unsigned *);
static void init_stringtab (bfd *, file_ptr, struct objfile *);
@@ -215,8 +214,7 @@ static void xcoff_new_init (struct objfi
static void xcoff_symfile_finish (struct objfile *);
-static void
-xcoff_symfile_offsets (struct objfile *, struct section_addr_info *addrs);
+static void xcoff_symfile_offsets (struct objfile *, struct section_addr_info *addrs);
static void find_linenos (bfd *, sec_ptr, PTR);
Index: config/alpha/tm-alpha.h
===================================================================
RCS file: /cvs/src/src/gdb/config/alpha/tm-alpha.h,v
retrieving revision 1.4
diff -p -u -w -r1.4 tm-alpha.h
--- config/alpha/tm-alpha.h 2000/05/28 01:12:34 1.4
+++ config/alpha/tm-alpha.h 2001/01/25 20:56:18
@@ -1,6 +1,6 @@
/* Definitions to make GDB run on an Alpha box under OSF1. This is
- also used by the Alpha/Netware and Alpha/Linux targets.
- Copyright 1993, 1994, 1995, 1996 Free Software Foundation, Inc.
+ also used by the Alpha/Netware and Alpha/Linux targets. Copyright
+ 1993, 1994, 1995, 1996, 2001 Free Software Foundation, Inc.
This file is part of GDB.
@@ -182,16 +182,14 @@ extern CORE_ADDR alpha_saved_pc_after_ca
#define REGISTER_CONVERT_TO_VIRTUAL(REGNUM, TYPE, FROM, TO) \
alpha_register_convert_to_virtual (REGNUM, TYPE, FROM, TO)
-extern void
-alpha_register_convert_to_virtual (int, struct type *, char *, char *);
+extern void alpha_register_convert_to_virtual (int, struct type *, char *, char *);
/* Convert data from virtual format with type TYPE in buffer FROM
to raw format for register REGNUM in buffer TO. */
#define REGISTER_CONVERT_TO_RAW(TYPE, REGNUM, FROM, TO) \
alpha_register_convert_to_raw (TYPE, REGNUM, FROM, TO)
-extern void
-alpha_register_convert_to_raw (struct type *, int, char *, char *);
+extern void alpha_register_convert_to_raw (struct type *, int, char *, char *);
/* Return the GDB type object for the "standard" data type
of data in register N. */
@@ -308,8 +306,7 @@ extern void alpha_find_saved_regs (struc
#define PUSH_ARGUMENTS(nargs, args, sp, struct_return, struct_addr) \
(alpha_push_arguments((nargs), (args), (sp), (struct_return), (struct_addr)))
-extern CORE_ADDR
-alpha_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
+extern CORE_ADDR alpha_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
/* Push an empty stack frame, to record the current PC, etc. */
Index: config/pa/tm-hppa.h
===================================================================
RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v
retrieving revision 1.5
diff -p -u -w -r1.5 tm-hppa.h
--- config/pa/tm-hppa.h 2000/08/04 03:17:57 1.5
+++ config/pa/tm-hppa.h 2001/01/25 20:56:19
@@ -1,5 +1,6 @@
/* Parameters for execution on any Hewlett-Packard PA-RISC machine.
- Copyright 1986, 1987, 1989-1993, 1995, 1999, 2000 Free Software Foundation, Inc.
+ Copyright 1986, 1987, 1989-1993, 1995, 1999, 2000, 2001 Free
+ Software Foundation, Inc.
Contributed by the Center for Software Science at the
University of Utah (pa-gdb-bugs@cs.utah.edu).
@@ -458,8 +459,7 @@ extern CORE_ADDR hppa_frame_saved_pc (st
#define FRAME_FIND_SAVED_REGS(frame_info, frame_saved_regs) \
hppa_frame_find_saved_regs (frame_info, &frame_saved_regs)
-extern void
-hppa_frame_find_saved_regs (struct frame_info *, struct frame_saved_regs *);
+extern void hppa_frame_find_saved_regs (struct frame_info *, struct frame_saved_regs *);
\f
/* Things needed for making the inferior call functions. */
@@ -623,8 +623,7 @@ hppa_fix_call_dummy (char *, CORE_ADDR,
#define PUSH_ARGUMENTS(nargs, args, sp, struct_return, struct_addr) \
(hppa_push_arguments((nargs), (args), (sp), (struct_return), (struct_addr)))
-extern CORE_ADDR
-hppa_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
+extern CORE_ADDR hppa_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
\f
/* The low two bits of the PC on the PA contain the privilege level. Some
genius implementing a (non-GCC) compiler apparently decided this means
Index: config/sparc/tm-sp64.h
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/tm-sp64.h,v
retrieving revision 1.3
diff -p -u -w -r1.3 tm-sp64.h
--- config/sparc/tm-sp64.h 2000/05/28 01:12:41 1.3
+++ config/sparc/tm-sp64.h 2001/01/25 20:56:20
@@ -109,14 +109,12 @@
#define FIX_CALL_DUMMY(DUMMYNAME, PC, FUN, NARGS, ARGS, TYPE, GCC_P)
#undef PUSH_RETURN_ADDRESS
#define PUSH_RETURN_ADDRESS(PC, SP) sparc_at_entry_push_return_address (PC, SP)
-extern CORE_ADDR
-sparc_at_entry_push_return_address (CORE_ADDR pc, CORE_ADDR sp);
+extern CORE_ADDR sparc_at_entry_push_return_address (CORE_ADDR pc, CORE_ADDR sp);
#undef STORE_STRUCT_RETURN
#define STORE_STRUCT_RETURN(ADDR, SP) \
sparc_at_entry_store_struct_return (ADDR, SP)
-extern void
-sparc_at_entry_store_struct_return (CORE_ADDR addr, CORE_ADDR sp);
+extern void sparc_at_entry_store_struct_return (CORE_ADDR addr, CORE_ADDR sp);
#else
Index: config/sparc/tm-sparc.h
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/tm-sparc.h,v
retrieving revision 1.5
diff -p -u -w -r1.5 tm-sparc.h
--- config/sparc/tm-sparc.h 2000/05/28 01:12:41 1.5
+++ config/sparc/tm-sparc.h 2001/01/25 20:56:21
@@ -704,8 +704,7 @@ void sparc_pop_frame (void);
#define PUSH_ARGUMENTS(NARGS, ARGS, SP, STRUCT_RETURN, STRUCT_ADDR) \
sparc32_push_arguments (NARGS, ARGS, SP, STRUCT_RETURN, STRUCT_ADDR)
-extern CORE_ADDR
-sparc32_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
+extern CORE_ADDR sparc32_push_arguments (int, struct value **, CORE_ADDR, int, CORE_ADDR);
/* Store the address of the place in which to copy the structure the
subroutine will return. This is called from call_function_by_hand.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH, RFA]: Revamp NaN detection & discussion
2001-01-25 13:03 [PATCH, RFA]: Revamp NaN detection & discussion Mark Kettenis
@ 2001-03-21 6:40 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2001-03-21 6:40 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches, gdb, taylor
> I also have an itch about floatformat.{ch} and its functions. I'd
> rather put all floatformat_* functions in there rather than in
> defs.h/utils.c. But since it's part of libiberty that's a bit of a
> pain. Is this stuff really used anywhere outside GDB? If not,
> perhaps we could claim it back. Otherwise I'd like to add a
> gdb_floatformat.{ch} and put all the floatformat stuff there.
Hmm, looked in the TODO file? (I'll append all the comments).
Given that no one appears to be using floatformat (unless GCC is?) I
think we can ``claim it back''.
At a more idealistic level we could instead use sim/common/sim-fpu.[ch]
and implement GDB's target floating point using that. I can but dream
:-)
Andrew
PS: The harris mess is sorted out - harris is obsolete.
--
Rationalize use of floatformat_unknown in GDB sources.
Instead of defaulting to floatformat_unknown, should hosts/targets
specify the value explicitly?
http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html
--
Add a ``name'' member to include/floatformat.h:struct floatformat.
Print that name in gdbarch.c.
--
Sort out the harris mess in include/floatformat.h (it hardwires two
different floating point formats).
--
See of the GDB local floatformat_do_doublest() and libiberty's
floatformat_to_double (which was once GDB's ...) can be merged some
how.
--
Deprecate current use of ``floatformat_unknown''.
Require all targets to explicitly provide their float format instead
of defaulting to floatformat unknown. Doing the latter leads to nasty
bugs.
http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html
--
Rationalize floatformat_to_double() vs floatformat_to_doublest().
Looks like GDB migrated floatformat_to_double() to libiberty but then
turned around and created a ..._to_doublest() the latter containing
several bug fixes.
http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00472.html
--
Move floatformat_ia64_ext to libiberty/include floatformat.[ch].
http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00466.html
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-03-21 6:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-01-25 13:03 [PATCH, RFA]: Revamp NaN detection & discussion Mark Kettenis
2001-03-21 6:40 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox