From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Mark Kettenis Cc: gdb-patches@sources.redhat.com, gdb@sources.redhat.com, taylor@cygnus.com Subject: Re: [PATCH, RFA]: Revamp NaN detection & discussion Date: Wed, 21 Mar 2001 06:40:00 -0000 Message-id: <3AB8B4FE.1A7F7C9@cygnus.com> References: <200101252103.f0PL3ig00326@delius.kettenis.local> X-SW-Source: 2001-03/msg00400.html > I also have an itch about floatformat.{ch} and its functions. I'd > rather put all floatformat_* functions in there rather than in > defs.h/utils.c. But since it's part of libiberty that's a bit of a > pain. Is this stuff really used anywhere outside GDB? If not, > perhaps we could claim it back. Otherwise I'd like to add a > gdb_floatformat.{ch} and put all the floatformat stuff there. Hmm, looked in the TODO file? (I'll append all the comments). Given that no one appears to be using floatformat (unless GCC is?) I think we can ``claim it back''. At a more idealistic level we could instead use sim/common/sim-fpu.[ch] and implement GDB's target floating point using that. I can but dream :-) Andrew PS: The harris mess is sorted out - harris is obsolete. -- Rationalize use of floatformat_unknown in GDB sources. Instead of defaulting to floatformat_unknown, should hosts/targets specify the value explicitly? http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html -- Add a ``name'' member to include/floatformat.h:struct floatformat. Print that name in gdbarch.c. -- Sort out the harris mess in include/floatformat.h (it hardwires two different floating point formats). -- See of the GDB local floatformat_do_doublest() and libiberty's floatformat_to_double (which was once GDB's ...) can be merged some how. -- Deprecate current use of ``floatformat_unknown''. Require all targets to explicitly provide their float format instead of defaulting to floatformat unknown. Doing the latter leads to nasty bugs. http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00447.html -- Rationalize floatformat_to_double() vs floatformat_to_doublest(). Looks like GDB migrated floatformat_to_double() to libiberty but then turned around and created a ..._to_doublest() the latter containing several bug fixes. http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00472.html -- Move floatformat_ia64_ext to libiberty/include floatformat.[ch]. http://sourceware.cygnus.com/ml/gdb-patches/2000-05/msg00466.html --