Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file
Date: Wed, 12 Apr 2017 14:46:00 -0000	[thread overview]
Message-ID: <1fa86b25-7201-bdbc-8494-e4262fcc9d5e@redhat.com> (raw)
In-Reply-To: <838tn5k7pu.fsf@gnu.org>

On 04/12/2017 03:42 PM, Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>
>> Date: Wed, 12 Apr 2017 15:07:02 +0100
>>
>>> The comment in i386-tdep.c says:
>>>
>>>   /* There are a few i386 architecture variants that differ only
>>>      slightly from the generic i386 target.  For now, we don't give them
>>>      their own source file, but include them here.  As a consequence,
>>>      they'll always be included.  */
>>>
>>> If we are going to have a separate tdep file for such architectures,
>>> let's do it for SVR4 as well.
>>
>> That can be done, but I don't see why it has to be in the same patch?
> 
> It doesn't.

So to be clear, are you OK with the patch as is?

Thanks,
Pedro Alves


  reply	other threads:[~2017-04-12 14:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 13:31 Pedro Alves
2017-04-12 13:47 ` Eli Zaretskii
2017-04-12 14:07   ` Pedro Alves
2017-04-12 14:26     ` Pedro Alves
2017-04-12 14:45       ` Eli Zaretskii
2017-04-12 14:57         ` Pedro Alves
2017-04-12 15:32           ` Pedro Alves
2017-04-12 14:42     ` Eli Zaretskii
2017-04-12 14:46       ` Pedro Alves [this message]
2017-04-12 14:58         ` Eli Zaretskii
2017-04-12 15:02           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fa86b25-7201-bdbc-8494-e4262fcc9d5e@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox