From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11988 invoked by alias); 12 Apr 2017 14:46:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11654 invoked by uid 89); 12 Apr 2017 14:46:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:782 X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:46:02 +0000 Received: by mail-wm0-f54.google.com with SMTP id u2so25876121wmu.0 for ; Wed, 12 Apr 2017 07:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=bTom6wUdBcpfcBGkMHXFx8arwOp8bexuwg4RPn1YB6A=; b=GcWaTnRYKFYlXY86X7DQflViCBG+itWbI6tAInvpAYHAAgJYtJcIPrzxLiDisVJhUO 98zW3GrVQVRPygGmmkubww3A22PnIw03tTZ8OLNp6NiTYBCSu6zFCsQ1bG73kekSQtef skFctjf1iUfoqLT0Sqs7m1JFP+LtL65QlrEOzDp5+COMns1GN7pTN80XaFgnI2fINmPy LaqzHL31aFc9QtZ6H1YCsVtilWsR1E60y8GgSzX7OH8L2VF+MtH3ZQxSlIrdI1Wgsasm YyiKxPXHca9sJvjHSPIJps9Bj8X78TX3U5Sh/4Aepsd9GjE7+1ShAh1yFO6cjqCYgbyo 6x7Q== X-Gm-Message-State: AN3rC/5Uk+nVO+fzjyLb5iejCwhx5E0MlnHtpMAodiBW7PnVFIA4pJeVicLcdjcVaNN7WofG X-Received: by 10.28.71.8 with SMTP id u8mr3257001wma.39.1492008361430; Wed, 12 Apr 2017 07:46:01 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id g10sm25946019wrb.56.2017.04.12.07.46.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 07:46:00 -0700 (PDT) Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file To: Eli Zaretskii References: <1492003875-25394-1-git-send-email-palves@redhat.com> <83bms1ka9s.fsf@gnu.org> <838tn5k7pu.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1fa86b25-7201-bdbc-8494-e4262fcc9d5e@redhat.com> Date: Wed, 12 Apr 2017 14:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <838tn5k7pu.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00339.txt.bz2 On 04/12/2017 03:42 PM, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Wed, 12 Apr 2017 15:07:02 +0100 >> >>> The comment in i386-tdep.c says: >>> >>> /* There are a few i386 architecture variants that differ only >>> slightly from the generic i386 target. For now, we don't give them >>> their own source file, but include them here. As a consequence, >>> they'll always be included. */ >>> >>> If we are going to have a separate tdep file for such architectures, >>> let's do it for SVR4 as well. >> >> That can be done, but I don't see why it has to be in the same patch? > > It doesn't. So to be clear, are you OK with the patch as is? Thanks, Pedro Alves