From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add test for following fork on position-independent executables
Date: Wed, 11 Apr 2018 18:54:00 -0000 [thread overview]
Message-ID: <1cad6bb0489875e91db2562785d7fd17@polymtl.ca> (raw)
In-Reply-To: <018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com>
On 2018-04-11 14:24, Pedro Alves wrote:
> On 04/11/2018 04:28 PM, Simon Marchi wrote:
>
>> +static void
>> +break_here ()
>
> This is C, so "(void)" is better here.
Fixed.
>> +{
>> + int i;
>> + for (i = 0; i < 30; i++)
>> + sleep (1);
>> +}
>> +
>> +int
>> +main ()
>> +{
>> + fork ();
>> + break_here();
>
> Missing space before parens.
Fixed.
>> +if [use_gdb_stub] {
>> + return
>> +}
>> +
> I guess this is why you were asking about following forks and
> "target remote". AFAICT, this should just work in that case
> too. Did you find out it doesn't?
No it works actually, and I was suprised :). I'll remove that "if".
> Otherwise looks fine. Thanks for adding this.
Thanks, I'll push with those things fixed.
Simon
prev parent reply other threads:[~2018-04-11 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 15:29 Simon Marchi
2018-04-11 18:24 ` Pedro Alves
2018-04-11 18:54 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cad6bb0489875e91db2562785d7fd17@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox