From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add test for following fork on position-independent executables
Date: Wed, 11 Apr 2018 18:24:00 -0000 [thread overview]
Message-ID: <018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com> (raw)
In-Reply-To: <1523460523-19370-1-git-send-email-simon.marchi@ericsson.com>
On 04/11/2018 04:28 PM, Simon Marchi wrote:
> +static void
> +break_here ()
This is C, so "(void)" is better here.
> +{
> + int i;
> + for (i = 0; i < 30; i++)
> + sleep (1);
> +}
> +
> +int
> +main ()
> +{
> + fork ();
> + break_here();
Missing space before parens.
> +if [use_gdb_stub] {
> + return
> +}
> +
I guess this is why you were asking about following forks and
"target remote". AFAICT, this should just work in that case
too. Did you find out it doesn't?
Otherwise looks fine. Thanks for adding this.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-04-11 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 15:29 Simon Marchi
2018-04-11 18:24 ` Pedro Alves [this message]
2018-04-11 18:54 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox