From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146527-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4684 invoked by alias); 11 Apr 2018 18:24:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4505 invoked by uid 89); 11 Apr 2018 18:24:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Apr 2018 18:24:20 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 351F9406F969;	Wed, 11 Apr 2018 18:24:04 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id B50592024CA4;	Wed, 11 Apr 2018 18:24:03 +0000 (UTC)
Subject: Re: [PATCH] Add test for following fork on position-independent executables
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
References: <1523460523-19370-1-git-send-email-simon.marchi@ericsson.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com>
Date: Wed, 11 Apr 2018 18:24:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1523460523-19370-1-git-send-email-simon.marchi@ericsson.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00219.txt.bz2

On 04/11/2018 04:28 PM, Simon Marchi wrote:

> +static void
> +break_here ()

This is C, so "(void)" is better here.

> +{
> +   int i;
> +   for (i = 0; i < 30; i++)
> +     sleep (1);
> +}
> +
> +int
> +main ()
> +{
> +  fork ();
> +  break_here();

Missing space before parens.

> +if [use_gdb_stub] {
> +    return
> +}
> +
I guess this is why you were asking about following forks and
"target remote".  AFAICT, this should just work in that case
too.  Did you find out it doesn't?

Otherwise looks fine.  Thanks for adding this.

Thanks,
Pedro Alves