From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74720 invoked by alias); 11 Apr 2018 18:54:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74693 invoked by uid 89); 11 Apr 2018 18:54:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Apr 2018 18:54:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w3BIrsTO003670 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Apr 2018 14:53:59 -0400 Received: by simark.ca (Postfix, from userid 112) id 3EDB11EF60; Wed, 11 Apr 2018 14:53:54 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CDFF01E073; Wed, 11 Apr 2018 14:53:52 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 11 Apr 2018 18:54:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Add test for following fork on position-independent executables In-Reply-To: <018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com> References: <1523460523-19370-1-git-send-email-simon.marchi@ericsson.com> <018bbd6b-a4fe-a8ca-e7cd-54919ac30de7@redhat.com> Message-ID: <1cad6bb0489875e91db2562785d7fd17@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 11 Apr 2018 18:53:54 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00222.txt.bz2 On 2018-04-11 14:24, Pedro Alves wrote: > On 04/11/2018 04:28 PM, Simon Marchi wrote: > >> +static void >> +break_here () > > This is C, so "(void)" is better here. Fixed. >> +{ >> + int i; >> + for (i = 0; i < 30; i++) >> + sleep (1); >> +} >> + >> +int >> +main () >> +{ >> + fork (); >> + break_here(); > > Missing space before parens. Fixed. >> +if [use_gdb_stub] { >> + return >> +} >> + > I guess this is why you were asking about following forks and > "target remote". AFAICT, this should just work in that case > too. Did you find out it doesn't? No it works actually, and I was suprised :). I'll remove that "if". > Otherwise looks fine. Thanks for adding this. Thanks, I'll push with those things fixed. Simon