bug in gdb

bug in gdb

[dhawkins]

Found a bug in gdb.  This seems to be the correct fix.  (I give the
code unconditionally to the FSF for what ever they wish to do with
it..., yadda, yadda, yadda).  It does not seem to warrant much
fanfare. 

Changelog entry:
  Fixed a bug where the typevec_size was not being reset to zero after
  the typevec itself had been reset.

--- gdb-4.18.borked/libiberty/cplus-dem.c	Thu Apr  1 20:37:06 1999
+++ gdb-4.18/libiberty/cplus-dem.c	Sat Apr 17 22:50:39 1999
@@ -880,6 +880,8 @@
     {
       free ((char *) work -> typevec);
       work -> typevec = NULL;
+      /* DKH --- The size was not being reset to 0... */
+      work -> typevec_size = 0;
     }
   if (work->tmpl_argvec)
     {

-Dale

-- 
With the mochas, he was strong.
-- E. Hemingway

Beer is proof that God loves us and wants us to be happy.
-- Benjamin Franklin

   Dale K. Hawkins          ||   Your work, no matter how brilliant,
   dhawkins@dimensional.com ||   becomes valuable to others only in
   To Hack, is to Live!     ||   so far as you communicate it to them.

Re: bug in gdb

[Jim Blandy]

> Found a bug in gdb.  This seems to be the correct fix.  (I give the
> code unconditionally to the FSF for what ever they wish to do with
> it..., yadda, yadda, yadda).  It does not seem to warrant much
> fanfare. 

For a change this small, we don't need a copyright assignment.  It's
not large enough to be copyrightable.

> Changelog entry:
>   Fixed a bug where the typevec_size was not being reset to zero after
>   the typevec itself had been reset.

The fix looks reasonable, but can you give me an identifier to
demangle that makes the bug appear?
From shebs@cygnus.com Mon Apr 19 14:08:00 1999
From: Stan Shebs <shebs@cygnus.com>
To: robertl@sco.com
Cc: gdb-patches@cygnus.com
Subject: Re: GDB 4.18 on SVR5: missed it by a hair
Date: Mon, 19 Apr 1999 14:08:00 -0000
Message-id: <199904192047.NAA18881@andros.cygnus.com>
References: <19990415225503.A10488@rjlhome.sco.com>
X-SW-Source: 1999-04/msg00040.html
Content-length: 414

   Date: Thu, 15 Apr 1999 22:55:03 -0500
   From: Robert Lipe <robertl@sco.com>

   The round of optimizations we performed on configure.host didn't
   make it to configure.tgt.   So SVR5 gets detected as SVR4.0 so it
   gets /proc filesystem handling silently wrong. :-(

Argh!  The change is in the trunk, but I forget to add it to the 4.18
branch also.  Well, there's a third patch for 4.18.1...

								Stan

Re: bug in gdb

[Jim Blandy]

> Found a bug in gdb.  This seems to be the correct fix.  (I give the
> code unconditionally to the FSF for what ever they wish to do with
> it..., yadda, yadda, yadda).  It does not seem to warrant much
> fanfare. 

For a change this small, we don't need a copyright assignment.  It's
not large enough to be copyrightable.

> Changelog entry:
>   Fixed a bug where the typevec_size was not being reset to zero after
>   the typevec itself had been reset.

The fix looks reasonable, but can you give me an identifier to
demangle that makes the bug appear?