From: Stan Shebs <shebs@cygnus.com>
To: phdm@macqel.be
Cc: gdb-patches@cygnus.com
Subject: Re: coffread.c and one-line functions
Date: Wed, 14 Apr 1999 13:21:00 -0000 [thread overview]
Message-ID: <199904141910.MAA12592@andros.cygnus.com> (raw)
In-Reply-To: <199904080450.GAA31507@mail.macqel.be>
Date: Thu, 8 Apr 1999 06:50:03 +0200 (CEST)
From: "Philippe De Muyter" <phdm@macqel.be>
Thu Apr 8 06:26:12 1999 Philippe De Muyter <phdm@macqel.be>
* breakpoint.c (maintenance_info_breakpoints): Function made static
to match previous prototype.
* coffread.c (coff_record_line): Static function removed.
(enter_linenos): Call `record_line' instead of `coff_record_line'.
(FILE-LEVEL, coff_start_symtab, coff_end_symtab): `coff_record_line'
-related stuff removed.
(coff_symfile_read): Redundant statement removed.
(coff_symtab_read): `record_line' is now called with the first line
number of each function, given by the ".bf" symbol. This solves
the line-number bug for one-line functions.
This all looks plausible to me, I will install it into the repository.
I especially like the part where redundant code has been removed!
Stan
WARNING: multiple messages have this Message-ID
From: Stan Shebs <shebs@cygnus.com>
To: phdm@macqel.be
Cc: gdb-patches@cygnus.com
Subject: Re: coffread.c and one-line functions
Date: Wed, 14 Apr 1999 12:10:00 -0000 [thread overview]
Message-ID: <199904141910.MAA12592@andros.cygnus.com> (raw)
Message-ID: <19990414121000.gGMD2rm5GNCAxRVBxyIFYmne4le8TjqWIFnLdG-8Psk@z> (raw)
In-Reply-To: <199904080450.GAA31507@mail.macqel.be>
Date: Thu, 8 Apr 1999 06:50:03 +0200 (CEST)
From: "Philippe De Muyter" <phdm@macqel.be>
Thu Apr 8 06:26:12 1999 Philippe De Muyter <phdm@macqel.be>
* breakpoint.c (maintenance_info_breakpoints): Function made static
to match previous prototype.
* coffread.c (coff_record_line): Static function removed.
(enter_linenos): Call `record_line' instead of `coff_record_line'.
(FILE-LEVEL, coff_start_symtab, coff_end_symtab): `coff_record_line'
-related stuff removed.
(coff_symfile_read): Redundant statement removed.
(coff_symtab_read): `record_line' is now called with the first line
number of each function, given by the ".bf" symbol. This solves
the line-number bug for one-line functions.
This all looks plausible to me, I will install it into the repository.
I especially like the part where redundant code has been removed!
Stan
next prev parent reply other threads:[~1999-04-14 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-07 21:50 Philippe De Muyter
1999-04-07 22:49 ` Philippe De Muyter
1999-04-14 13:21 ` Stan Shebs [this message]
1999-04-14 12:10 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199904141910.MAA12592@andros.cygnus.com \
--to=shebs@cygnus.com \
--cc=gdb-patches@cygnus.com \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox