From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stan Shebs To: phdm@macqel.be Cc: gdb-patches@cygnus.com Subject: Re: coffread.c and one-line functions Date: Wed, 14 Apr 1999 13:21:00 -0000 Message-id: <199904141910.MAA12592@andros.cygnus.com> References: <199904080450.GAA31507@mail.macqel.be> X-SW-Source: 1999-04/msg00031.html Date: Thu, 8 Apr 1999 06:50:03 +0200 (CEST) From: "Philippe De Muyter" Thu Apr 8 06:26:12 1999 Philippe De Muyter * breakpoint.c (maintenance_info_breakpoints): Function made static to match previous prototype. * coffread.c (coff_record_line): Static function removed. (enter_linenos): Call `record_line' instead of `coff_record_line'. (FILE-LEVEL, coff_start_symtab, coff_end_symtab): `coff_record_line' -related stuff removed. (coff_symfile_read): Redundant statement removed. (coff_symtab_read): `record_line' is now called with the first line number of each function, given by the ".bf" symbol. This solves the line-number bug for one-line functions. This all looks plausible to me, I will install it into the repository. I especially like the part where redundant code has been removed! Stan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stan Shebs To: phdm@macqel.be Cc: gdb-patches@cygnus.com Subject: Re: coffread.c and one-line functions Date: Wed, 14 Apr 1999 12:10:00 -0000 Message-ID: <199904141910.MAA12592@andros.cygnus.com> References: <199904080450.GAA31507@mail.macqel.be> X-SW-Source: 1999-q2/msg00029.html Message-ID: <19990414121000.gGMD2rm5GNCAxRVBxyIFYmne4le8TjqWIFnLdG-8Psk@z> Date: Thu, 8 Apr 1999 06:50:03 +0200 (CEST) From: "Philippe De Muyter" Thu Apr 8 06:26:12 1999 Philippe De Muyter * breakpoint.c (maintenance_info_breakpoints): Function made static to match previous prototype. * coffread.c (coff_record_line): Static function removed. (enter_linenos): Call `record_line' instead of `coff_record_line'. (FILE-LEVEL, coff_start_symtab, coff_end_symtab): `coff_record_line' -related stuff removed. (coff_symfile_read): Redundant statement removed. (coff_symtab_read): `record_line' is now called with the first line number of each function, given by the ".bf" symbol. This solves the line-number bug for one-line functions. This all looks plausible to me, I will install it into the repository. I especially like the part where redundant code has been removed! Stan