Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* 4.17.85 Feedback
@ 1999-03-04  8:22 Mark Kettenis
  1999-04-01  0:00 ` Michael Snyder
  1999-04-01  0:00 ` Mark Kettenis
  0 siblings, 2 replies; 4+ messages in thread
From: Mark Kettenis @ 1999-03-04  8:22 UTC (permalink / raw)
  To: gdb-patches

I have tested the prerelease on the Hurd and encountered some small
compilation problems.

The first problem is caused by the following change:

Thu Dec 31 16:54:30 1998  David Taylor  <taylor@texas.cygnus.com>

        * inferior.h (proc_wait): Declare.

The Hurd already has a proc_wait RPC so the prototype in
<hurd/process.h> clashes with the one in "inferior.h".  Both files
need to be included in `gnu-nat.c' since it implements some of the
functions in "inferior.h" by using functions provided by
<hurd/process.h>.  Is there any chance that th above patch will be
reverted?  Of course it is possible to hack around the prototype
clash, by writing

#define proc_wait xxx_proc_wait
#include <hurd/process.h>
#undef proc_wait

but that's a bit ugly.  Anyway if that's the way to go, I'll provide
the patch, hust ask me.

I'll send some patches to solve the other problems later today.

Anyway, gdb 4.17.85 seems to work just as well as 4.17 did.

Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 4.17.85 Feedback
  1999-04-01  0:00 ` Michael Snyder
@ 1999-03-04  9:19   ` Michael Snyder
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Snyder @ 1999-03-04  9:19 UTC (permalink / raw)
  To: gdb-patches; +Cc: gdb-local

Mark Kettenis wrote:
> 
> The first problem is caused by the following change:
> 
> Thu Dec 31 16:54:30 1998  David Taylor  <taylor@texas.cygnus.com>
> 
>         * inferior.h (proc_wait): Declare.
> 
> The Hurd already has a proc_wait RPC so the prototype in
> <hurd/process.h> clashes with the one in "inferior.h".

The most obvious fix would be for one of us to change the name
of his function.  ;-)

Since the Hurd has been using the name longer, you have 
seniority.  I suggest that the function in infptrace.c, 
added in 12/98, be renamed.  If no one objects, I will 
take care of it -- but I'm not sure if it will make it 
into 4.18, which is very close to release.

				Michael


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 4.17.85 Feedback
  1999-03-04  8:22 4.17.85 Feedback Mark Kettenis
@ 1999-04-01  0:00 ` Michael Snyder
  1999-03-04  9:19   ` Michael Snyder
  1999-04-01  0:00 ` Mark Kettenis
  1 sibling, 1 reply; 4+ messages in thread
From: Michael Snyder @ 1999-04-01  0:00 UTC (permalink / raw)
  To: gdb-patches; +Cc: gdb-local

Mark Kettenis wrote:
> 
> The first problem is caused by the following change:
> 
> Thu Dec 31 16:54:30 1998  David Taylor  <taylor@texas.cygnus.com>
> 
>         * inferior.h (proc_wait): Declare.
> 
> The Hurd already has a proc_wait RPC so the prototype in
> <hurd/process.h> clashes with the one in "inferior.h".

The most obvious fix would be for one of us to change the name
of his function.  ;-)

Since the Hurd has been using the name longer, you have 
seniority.  I suggest that the function in infptrace.c, 
added in 12/98, be renamed.  If no one objects, I will 
take care of it -- but I'm not sure if it will make it 
into 4.18, which is very close to release.

				Michael


^ permalink raw reply	[flat|nested] 4+ messages in thread

* 4.17.85 Feedback
  1999-03-04  8:22 4.17.85 Feedback Mark Kettenis
  1999-04-01  0:00 ` Michael Snyder
@ 1999-04-01  0:00 ` Mark Kettenis
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 1999-04-01  0:00 UTC (permalink / raw)
  To: gdb-patches

I have tested the prerelease on the Hurd and encountered some small
compilation problems.

The first problem is caused by the following change:

Thu Dec 31 16:54:30 1998  David Taylor  <taylor@texas.cygnus.com>

        * inferior.h (proc_wait): Declare.

The Hurd already has a proc_wait RPC so the prototype in
<hurd/process.h> clashes with the one in "inferior.h".  Both files
need to be included in `gnu-nat.c' since it implements some of the
functions in "inferior.h" by using functions provided by
<hurd/process.h>.  Is there any chance that th above patch will be
reverted?  Of course it is possible to hack around the prototype
clash, by writing

#define proc_wait xxx_proc_wait
#include <hurd/process.h>
#undef proc_wait

but that's a bit ugly.  Anyway if that's the way to go, I'll provide
the patch, hust ask me.

I'll send some patches to solve the other problems later today.

Anyway, gdb 4.17.85 seems to work just as well as 4.17 did.

Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1999-04-01  0:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-03-04  8:22 4.17.85 Feedback Mark Kettenis
1999-04-01  0:00 ` Michael Snyder
1999-03-04  9:19   ` Michael Snyder
1999-04-01  0:00 ` Mark Kettenis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox