From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Windows: Normalize backward slashes to forward slashes
Date: Mon, 6 Jul 2026 23:35:46 +0100 [thread overview]
Message-ID: <191532b6-db21-415d-876e-8854a0904ddd@palves.net> (raw)
In-Reply-To: <8733xwuxsd.fsf@redhat.com>
On 2026-07-06 13:07, Andrew Burgess wrote:
> Pedro Alves <pedro@palves.net> writes:
>> +struct scoped_normalized_path
>> +{
>> + explicit scoped_normalized_path (const char **path)
>> + {
>> + gdb_assert (path != nullptr);
>
> It's not a problem in any of the existing code, but maybe also:
>
> gdb_assert (*path != nullptr);
>
> otherwise we end up trying to create a std::string from NULL.
>
Thank you. I've merged the patch with this change.
Pedro Alves
> I looked through the rest of the changes, and it all looks reasonable to
> me.
>
> Reviewed-By: Andrew Burgess <aburgess@redhat.com>
prev parent reply other threads:[~2026-07-06 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 21:24 [PATCH] " Pedro Alves
2026-06-30 11:26 ` Eli Zaretskii
2026-06-30 14:47 ` Pedro Alves
2026-06-30 15:11 ` Eli Zaretskii
2026-07-01 11:28 ` [PATCH v2] " Pedro Alves
2026-07-01 12:07 ` Eli Zaretskii
2026-07-01 19:28 ` Pedro Alves
2026-07-02 5:28 ` Eli Zaretskii
2026-07-06 12:07 ` Andrew Burgess
2026-07-06 22:35 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191532b6-db21-415d-876e-8854a0904ddd@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox