From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4S7tA+ItTGp3RyoAWB0awg (envelope-from ) for ; Mon, 06 Jul 2026 18:36:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 004441E098; Mon, 06 Jul 2026 18:36:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D382B1E024 for ; Mon, 06 Jul 2026 18:36:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4169D4BA2E0D for ; Mon, 6 Jul 2026 22:36:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4169D4BA2E0D Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 2CD4C4BA2E09 for ; Mon, 6 Jul 2026 22:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CD4C4BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CD4C4BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783377351; cv=none; b=YCnwfe2oOkcrCmUUjIcRc26BgRUhWCMZzf7gW1BbSX7bTAupQwmgvTCytJ0JqZwtGVlv+ecKz5j+Wbouud9fJUSSidx+GTxsosez+/Wk7qHlNjl8QBhbPeSvRHz9kmDFc2QqvquweDUjbI8vyY6v9L7zsR1k190zZvZViErSqdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783377351; c=relaxed/simple; bh=pou9VIKVZhDkEP5VBCpRwK+J2BkGUfLZL8IVDHq5Otg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=WtHx7GR1ZaL022FJXmIzCeDXafhj8sOjs+9gIbbAIm+oeDUOSONghnxIqIJhbU5fXxdMbcrG5Pte3dApkk6d4w4XbxBmulDYzvrGM3zqNpKSd2TretDtHpoLIfcrS51pycchDWc9VVJRoYuYeDqbTmyxQv79Wznr0rq/LvDMmOU= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CD4C4BA2E09 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493b966dd74so11951085e9.3 for ; Mon, 06 Jul 2026 15:35:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783377350; x=1783982150; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eOzZuVh9rKV5OCG5jaIjQnKJaTdiv86eWx9NOSL6x4E=; b=JRkMC9wy4ebSv2sa5FttiOI58mx0iW5s9RrEVkNHLiIfqec9N20Mi7m553+j1A5sGA JW+7dgNc+GMjSk4VelRKkMtWGT3PxM/aqkwisieXY48HNZx62hzCrqvRJj3Z8HBLumK8 L/F+I+ZThmAbYbWc3wH9jmg9Un3ZexffXSVp9TWiU87EWiWvquhhD1nYRDrm9v55ndgl 0jp0fNqS9wehCZCjzEh4IwXTGkyxnWRIkQF6/JRA1SU71GTeVrRW2wEOMSQLmP9OYFWN FVifTt3EpyncZavNUhWM+HhbYwyr/MJ1FvDcyLrzYa6TS2r6M7qSJj7VUKBCGwPlcmSg tXuA== X-Gm-Message-State: AOJu0YzAclXYNKa/pX0c9EoU91S6lR8/DpoHMnTKpkqzGSLGruMuzJz1 LKdys7d5ntTVBxl7wQV3lGPuW/nKe8bjixaKQlDTaCi0MgXu1BuCplue X-Gm-Gg: AfdE7ckUKYOwbspBP31S0cyQ5CAq4N+pA1OGBLO+7s47Fzl6NIqyNyS6MB8O5qv2cbg tGfnxNwbRYAh5zrroU5+qqtbJ3XJB132+Og3HzKX0ZWk47TxZXKCsrWNyxMAfkX+datd+iC3x2l 97fUTizOaK3K6Oe0ODKqOXSOsBOfLIS4mSeoA/iwAoeH6g2mHkNAQXKJ3gpUYD+c8R4hGzc7/sA ED9oSnDR9NhsFwetglSAfWo2XdhcmQtOkSiJlF1jSByXoWU7NEdlcdPUD7TdgmY9G+wu07mhjJz 2vRim8ca2txRPvzJxVrhoR/EqNouCm/x2A4iVQ9YO3FYnRYxgBQ8d6u0MfgLGhJ3UcQW6o4OFd8 UDXTjsXMXopH7Tlnn/+R8wfbyOWMQuGj7cNteiB3y0xVMXmtM1es/kuGVH9T0uNK0sSWTkDa3mm YCWkgIVeFKNBpzWFyNG7Pl2mmgf+jeVYorYkM9QcE7sC7VBIEFPUHthew= X-Received: by 2002:a05:600c:4e92:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-493df04b124mr29634485e9.14.1783377349766; Mon, 06 Jul 2026 15:35:49 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac2:7700:a490:c68a:8b7b:4563? ([2001:8a0:fac2:7700:a490:c68a:8b7b:4563]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960816sm27198933f8f.29.2026.07.06.15.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 15:35:49 -0700 (PDT) Message-ID: <191532b6-db21-415d-876e-8854a0904ddd@palves.net> Date: Mon, 6 Jul 2026 23:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Windows: Normalize backward slashes to forward slashes To: Andrew Burgess , Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20260629212430.340516-1-pedro@palves.net> <867bnge0bc.fsf@gnu.org> <86qzlocbb4.fsf@gnu.org> <8733xwuxsd.fsf@redhat.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <8733xwuxsd.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-07-06 13:07, Andrew Burgess wrote: > Pedro Alves writes: >> +struct scoped_normalized_path >> +{ >> + explicit scoped_normalized_path (const char **path) >> + { >> + gdb_assert (path != nullptr); > > It's not a problem in any of the existing code, but maybe also: > > gdb_assert (*path != nullptr); > > otherwise we end up trying to create a std::string from NULL. > Thank you. I've merged the patch with this change. Pedro Alves > I looked through the rest of the changes, and it all looks reasonable to > me. > > Reviewed-By: Andrew Burgess