Re: [PATCH v2] Windows: Normalize backward slashes to forward slashes

[Andrew Burgess <aburgess@redhat.com>]

Pedro Alves <pedro@palves.net> writes:

> diff --git a/gdb/filesystem.h b/gdb/filesystem.h
> index 49f8e791ec4..d48d2508c70 100644
> --- a/gdb/filesystem.h
> +++ b/gdb/filesystem.h
> @@ -19,6 +19,8 @@
>  #ifndef GDB_FILESYSTEM_H
>  #define GDB_FILESYSTEM_H
>  
> +#include "gdbsupport/pathstuff.h"
> +
>  extern const char file_system_kind_auto[];
>  extern const char file_system_kind_unix[];
>  extern const char file_system_kind_dos_based[];
> @@ -55,4 +57,45 @@ extern const char *target_lbasename (const char *kind, const char *name);
>     result from this function.  */
>  extern const char *effective_target_file_system_kind (void);
>  
> +/* Return true if GDB should normalize backslashes to forward slashes.
> +   This is true if GDB is running on a system with a DOS-based
> +   filesystem (e.g., Windows), or, if cross debugging and the target
> +   itself has a DOS-based filesystem (e.g., remote debugging Windows
> +   GDBserver from Linux).  */
> +extern bool should_normalize_slashes ();
> +
> +/* Normalizes backslashes to forward slashes in a path string if
> +   necessary, extending the lifetime of the normalized copy for the
> +   duration of the object's scope.
> +
> +   The constructor takes a pointer-to-pointer and updates *PATH to
> +   point at the normalized string when normalization is needed, so
> +   callers need only:
> +
> +     scoped_normalized_path path_storage (&path);
> +
> +   and then use PATH directly without a separate reassignment.  */
> +struct scoped_normalized_path
> +{
> +  explicit scoped_normalized_path (const char **path)
> +  {
> +    gdb_assert (path != nullptr);

It's not a problem in any of the existing code, but maybe also:

  gdb_assert (*path != nullptr);

otherwise we end up trying to create a std::string from NULL.

I looked through the rest of the changes, and it all looks reasonable to
me.

Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew