From: Nick Roberts <nickrob@snap.net.nz>
To: "Marc Khouzam" <marc.khouzam@ericsson.com>
Cc: "Vladimir Prus" <ghost@cs.msu.su>, <gdb-patches@sources.redhat.com>
Subject: RE: Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME
Date: Thu, 03 Apr 2008 04:42:00 -0000 [thread overview]
Message-ID: <18419.63952.623990.501287@kahikatea.snap.net.nz> (raw)
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA0429101B@ecamlmw720.eamcs.ericsson.se>
Marc Khouzam writes:
>
> > * varobj.h (varobj_get_formatted_value): Declare.
> > > * varobj.c (my_value_of_variable): Added format parameter.
> > > (cplus_value_of_variable): Likewise.
> > > (java_value_of_variable): Likewise.
> > > (*(value_of_variable)): Likewise.
> >
> > Is '*(value_of_variable)' really a name of a function? :-)
>
> After Daniel's comment, I'm not too sure what you guys do
> for function pointers that are members....
> so I removed this Changelog entry. :-)
It still seems to be there.
(struct language_specific): Add format parameter to function member
*value_of_variable.
> > > +/* Parse a string argument into a format value. */
> >
> > As meta-remark, can you pass the "-p" option to diff when generating patches,
> > so that function names are present right in the patch?
>
>
> Sounds good but I'm not sure how to tell eclipse to do that...
> I'll keep looking, but until then, please forgive my patch since I ran
> it without
Put "diff -p" in your ~/.cvsrc?
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2008-04-02 21:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 14:33 Marc Khouzam
2008-04-02 0:17 ` Nick Roberts
2008-04-02 13:23 ` Marc Khouzam
2008-04-02 16:26 ` Vladimir Prus
2008-04-02 18:20 ` Michael Snyder
2008-04-02 18:50 ` Daniel Jacobowitz
2008-04-02 19:10 ` Marc Khouzam
2008-04-02 21:26 ` Marc Khouzam
2008-04-03 4:42 ` Nick Roberts [this message]
2008-04-04 15:07 ` Marc Khouzam
2008-04-06 6:42 ` OT: IDES [was RE: Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME] Nick Roberts
2008-04-06 22:46 ` Daniel Jacobowitz
2008-04-04 15:17 ` [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME Vladimir Prus
2008-04-08 17:04 ` Marc Khouzam
2008-04-08 22:24 ` Eli Zaretskii
2008-04-09 14:54 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18419.63952.623990.501287@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox