From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22719 invoked by alias); 2 Apr 2008 21:26:15 -0000 Received: (qmail 22711 invoked by uid 22791); 2 Apr 2008 21:26:14 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Apr 2008 21:25:49 +0000 Received: from kahikatea.snap.net.nz (81.60.255.123.dynamic.snap.net.nz [123.255.60.81]) by viper.snap.net.nz (Postfix) with ESMTP id E1BCC3DA0DF; Thu, 3 Apr 2008 10:25:44 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 6AB2E8FC6D; Thu, 3 Apr 2008 09:25:37 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <18419.63952.623990.501287@kahikatea.snap.net.nz> Date: Thu, 03 Apr 2008 04:42:00 -0000 To: "Marc Khouzam" Cc: "Vladimir Prus" , Subject: RE: Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA0429101B@ecamlmw720.eamcs.ericsson.se> References: <6D19CA8D71C89C43A057926FE0D4ADAA0429101B@ecamlmw720.eamcs.ericsson.se> X-Mailer: VM 7.19 under Emacs 22.1.92.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00049.txt.bz2 Marc Khouzam writes: >=20 > > =A0 =A0 =A0 =A0 * varobj.h (varobj_get_formatted_value): Declare. > > > =A0 =A0 =A0 =A0 * varobj.c (my_value_of_variable): Added format para= meter. > > > =A0 =A0 =A0 =A0 (cplus_value_of_variable): Likewise. > > > =A0 =A0 =A0 =A0 (java_value_of_variable): Likewise. > > > =A0 =A0 =A0 =A0 (*(value_of_variable)): Likewise. > >=20 > > Is '*(value_of_variable)' really a name of a function? :-) >=20 > After Daniel's comment, I'm not too sure what you guys do=20 > for function pointers that are members....=20 > so I removed this Changelog entry. :-) It still seems to be there. (struct language_specific): Add format parameter to function member *value_of_variable. > > > +/* Parse a string argument into a format value. =A0*/ > >=20 > > As meta-remark, can you pass the "-p" option to diff when generating p= atches, > > so that function names are present right in the patch? > >=20 > Sounds good but I'm not sure how to tell eclipse to do that... > I'll keep looking, but until then, please forgive my patch since I ran > it without Put "diff -p" in your ~/.cvsrc? --=20 Nick http://www.inet.net.nz/~nick= rob