Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: -var-update @
Date: Sun, 30 Mar 2008 03:54:00 -0000	[thread overview]
Message-ID: <18415.3808.504498.834488@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200803290937.57101.vladimir@codesourcery.com>

 > So, we still don't know why the current code does not work? I think
 > we still get to figure out, to make sure that whatever bug there is
 > does not affect other cases.

My patch didn't do the right thing (it always marked a floating variable
object as changed) but it's along the right lines.  How about this one?

-- 
Nick                                           http://www.inet.net.nz/~nickrob


2008-03-30  Nick Roberts  <nickrob@snap.net.nz>

	* varobj.c (value_of_root): Update expression of root for
	floating variable objects.



*** varobj.c.~1.108.~	2008-03-27 08:02:16.000000000 +1200
--- varobj.c	2008-03-30 15:41:44.000000000 +1200
*************** varobj_update (struct varobj **varp, str
*** 1739,1744 ****
--- 1739,1751 ----
        new_type = varobj_get_type (tmp_var);
        if (strcmp (old_type, new_type) == 0)
  	{
+ 	  struct expression *tmp_exp;
+ 
+ 	  /* Update expression to new frame.  */
+ 	  tmp_exp = var->root->exp;
+ 	  var->root->exp = tmp_var->root->exp;
+ 	  tmp_var->root->exp = tmp_exp;
+ 
  	  varobj_delete (tmp_var, NULL, 0);
  	  *type_changed = 0;
  	}


  reply	other threads:[~2008-03-30  3:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26 14:54 Vladimir Prus
2008-03-27  5:17 ` Nick Roberts
2008-03-27  7:00   ` Vladimir Prus
2008-03-27  9:54     ` Nick Roberts
2008-03-27 10:38       ` Vladimir Prus
2008-03-27 13:25         ` Marc Khouzam
2008-03-27 13:37           ` Vladimir Prus
2008-03-27 20:58           ` Nick Roberts
2008-03-28 14:32             ` Marc Khouzam
2008-03-28 16:22               ` Vladimir Prus
2008-03-28 16:33                 ` Marc Khouzam
2008-04-01 13:37             ` André Pönitz
2008-04-01 13:56               ` Marc Khouzam
2008-04-01 14:30                 ` André Pönitz
2008-04-03 19:10                   ` Daniel Jacobowitz
2008-04-03 19:31             ` Daniel Jacobowitz
2008-04-03 20:05               ` Michael Snyder
2008-03-29  5:16         ` Nick Roberts
2008-03-29  6:38           ` Vladimir Prus
2008-03-30  3:54             ` Nick Roberts [this message]
2008-04-03 18:55               ` Vladimir Prus
2008-04-03 21:30                 ` Nick Roberts
2008-04-04 11:45                   ` Vladimir Prus
2008-04-11 22:01                     ` Vladimir Prus
2008-04-11 23:22                       ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18415.3808.504498.834488@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox