From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Pedro Alves <pedro@codesourcery.com>,
GDB Patches <gdb-patches@sourceware.org>,
Vladimir Prus <vladimir@codesourcery.com>
Subject: Re: [linux] fix stepping over fork in follow-child mode.
Date: Wed, 19 Mar 2008 22:19:00 -0000 [thread overview]
Message-ID: <18401.37184.169763.462813@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080319160257.GA31587@caradoc.them.org>
> /* Building process ids. */
>
> #define GET_PID(ptid) ptid_get_pid (ptid)
> #define GET_LWP(ptid) ptid_get_lwp (ptid)
> -#define GET_THREAD(ptid) ptid_get_tid (ptid)
> -
> -#define is_lwp(ptid) (GET_LWP (ptid) != 0)
> -#define is_thread(ptid) (GET_THREAD (ptid) != 0)
>
> #define BUILD_LWP(lwp, pid) ptid_build (pid, lwp, 0)
Why not just put all these in linux-nat.h so there are not duplications in
linux-nat.c?
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2008-03-19 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 20:47 Pedro Alves
2008-03-18 23:48 ` Daniel Jacobowitz
[not found] ` <frqh16$7rk$1@ger.gmane.org>
2008-03-19 12:49 ` Daniel Jacobowitz
2008-03-19 16:03 ` Daniel Jacobowitz
2008-03-19 19:22 ` Joel Brobecker
2008-03-19 19:27 ` Daniel Jacobowitz
2008-03-19 22:19 ` Nick Roberts [this message]
2008-03-19 22:47 ` Daniel Jacobowitz
2008-03-21 15:45 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18401.37184.169763.462813@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox