Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [linux] fix stepping over fork in follow-child mode.
Date: Wed, 19 Mar 2008 19:22:00 -0000	[thread overview]
Message-ID: <20080319192237.GB3588@adacore.com> (raw)
In-Reply-To: <20080319160257.GA31587@caradoc.them.org>

Hi Daniel,

> > Here's an alternative fix.  Vladimir, this is also the patch I was
> > talking about earlier on IRC.  Not tested or finished yet.
> 
> Any comments?  Otherwise I'll commit this in a few days.

I'm really amazed at the amount of simplification this brings.
Never having looked at thread support on Linux, I had no idea...

I only have one very minor question: Why is the thread exit notification
now conditional on print_thread_events? I did notice that you changed
the few printf_filtered of such events into printf_unfiltered the same
way we did for the new thread events, which is nice :).

Thanks,
-- 
Joel


  reply	other threads:[~2008-03-19 19:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 20:47 Pedro Alves
2008-03-18 23:48 ` Daniel Jacobowitz
     [not found]   ` <frqh16$7rk$1@ger.gmane.org>
2008-03-19 12:49     ` Daniel Jacobowitz
2008-03-19 16:03   ` Daniel Jacobowitz
2008-03-19 19:22     ` Joel Brobecker [this message]
2008-03-19 19:27       ` Daniel Jacobowitz
2008-03-19 22:19     ` Nick Roberts
2008-03-19 22:47       ` Daniel Jacobowitz
2008-03-21 15:45         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080319192237.GB3588@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox