From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30920 invoked by alias); 19 Mar 2008 22:19:13 -0000 Received: (qmail 30911 invoked by uid 22791); 19 Mar 2008 22:19:12 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 22:18:45 +0000 Received: from kahikatea.snap.net.nz (115.62.255.123.dynamic.snap.net.nz [123.255.62.115]) by viper.snap.net.nz (Postfix) with ESMTP id 84BD93DAD19; Thu, 20 Mar 2008 11:18:43 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id DDF458FC6D; Thu, 20 Mar 2008 10:18:40 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18401.37184.169763.462813@kahikatea.snap.net.nz> Date: Wed, 19 Mar 2008 22:19:00 -0000 To: Daniel Jacobowitz Cc: Pedro Alves , GDB Patches , Vladimir Prus Subject: Re: [linux] fix stepping over fork in follow-child mode. In-Reply-To: <20080319160257.GA31587@caradoc.them.org> References: <200803182046.46420.pedro@codesourcery.com> <20080318234805.GA14989@caradoc.them.org> <20080319160257.GA31587@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.92.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00291.txt.bz2 > /* Building process ids. */ > > #define GET_PID(ptid) ptid_get_pid (ptid) > #define GET_LWP(ptid) ptid_get_lwp (ptid) > -#define GET_THREAD(ptid) ptid_get_tid (ptid) > - > -#define is_lwp(ptid) (GET_LWP (ptid) != 0) > -#define is_thread(ptid) (GET_THREAD (ptid) != 0) > > #define BUILD_LWP(lwp, pid) ptid_build (pid, lwp, 0) Why not just put all these in linux-nat.h so there are not duplications in linux-nat.c? -- Nick http://www.inet.net.nz/~nickrob