Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: [BUG:MI] -break-list doesn't list multiple breakpoints
Date: Tue, 29 Jan 2008 22:53:00 -0000	[thread overview]
Message-ID: <18335.44497.199685.970311@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080129185942.GA9019@caradoc.them.org>

 > > Here's a patch that fixes this but does much more.  The 'fix' works by
 > > removing the frame details in the MI output:
 > > 
 > > (gdb) 
 > > -break-insert 10
 > > ^done
 > 
 > Which is a backwards incompatible change, and other frontends use this
 > information; we can't remove it.

It's a backwards incompatible change but do other frontends use it?  In
principle you're right, of course, we can't remove it.  In practice, however,
some of the initial design was arbitrary and not born out of experience and
this is a public list where frontend developers can participate and have been
encouraged to do do.  They have an opportunity to object and such changes
might accelerate progress.

 > > this means that the condition:
 > > 
 > > 	  && !ui_out_is_mi_like_p (uiout))
 > > 
 > > can be removed from print_one_breakpoint so that -break-list prints
 > > details of all the multiple breakpoint locations.
 > 
 > I don't understand; how does this follow from the other change?

This code is executed by both -break-list and -break-insert.  By contrast,
ISTR that in CLI, it is executed by "info break" but not break.

As an alternative, I guess this line alone could be removed so that
-break-insert lists the multiple breakpoint locations being set and the
adjust MI documentation to explain this.

In any case, I think deprecated_set_gdb_event_hooks should go.  In CLI,
breakpoint details are printed in mention with say_where=1.  I don't really
understand why things need to differently for MI or why it can't be done
here too.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-01-29 22:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 22:08 Nick Roberts
2008-01-11 17:36 ` Vladimir Prus
2008-01-11 21:34   ` Nick Roberts
2008-01-11 22:55     ` Daniel Jacobowitz
2008-01-11 23:38       ` Nick Roberts
2008-01-15 17:08         ` Vladimir Prus
2008-01-15 21:38           ` Nick Roberts
2008-01-13 21:26       ` Nick Roberts
2008-01-29 19:16         ` Daniel Jacobowitz
2008-01-29 22:53           ` Nick Roberts [this message]
2008-01-29 23:31             ` Daniel Jacobowitz
2008-01-30  0:52               ` Nick Roberts
2008-01-30  3:04               ` Nick Roberts
2008-01-30  3:20                 ` Daniel Jacobowitz
2008-01-30  5:59                   ` Vladimir Prus
2008-01-30  7:14                     ` Nick Roberts
2008-01-30  7:32                       ` Vladimir Prus
2008-01-30  7:50                         ` Nick Roberts
2008-01-30  7:58                           ` Vladimir Prus
2008-02-01 20:15                   ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18335.44497.199685.970311@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox