From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25439 invoked by alias); 29 Jan 2008 22:51:58 -0000 Received: (qmail 25427 invoked by uid 22791); 29 Jan 2008 22:51:57 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jan 2008 22:51:07 +0000 Received: from kahikatea.snap.net.nz (116.61.255.123.dynamic.snap.net.nz [123.255.61.116]) by viper.snap.net.nz (Postfix) with ESMTP id B476F3D9F2B; Wed, 30 Jan 2008 11:50:59 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 22BEF8FC6D; Wed, 30 Jan 2008 11:50:58 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18335.44497.199685.970311@kahikatea.snap.net.nz> Date: Tue, 29 Jan 2008 22:53:00 -0000 To: Daniel Jacobowitz Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [BUG:MI] -break-list doesn't list multiple breakpoints In-Reply-To: <20080129185942.GA9019@caradoc.them.org> References: <18310.38708.144719.374963@kahikatea.snap.net.nz> <18311.57557.312425.107700@kahikatea.snap.net.nz> <20080111225452.GA26085@caradoc.them.org> <18314.33230.101539.472963@kahikatea.snap.net.nz> <20080129185942.GA9019@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 23.0.60.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00738.txt.bz2 > > Here's a patch that fixes this but does much more. The 'fix' works by > > removing the frame details in the MI output: > > > > (gdb) > > -break-insert 10 > > ^done > > Which is a backwards incompatible change, and other frontends use this > information; we can't remove it. It's a backwards incompatible change but do other frontends use it? In principle you're right, of course, we can't remove it. In practice, however, some of the initial design was arbitrary and not born out of experience and this is a public list where frontend developers can participate and have been encouraged to do do. They have an opportunity to object and such changes might accelerate progress. > > this means that the condition: > > > > && !ui_out_is_mi_like_p (uiout)) > > > > can be removed from print_one_breakpoint so that -break-list prints > > details of all the multiple breakpoint locations. > > I don't understand; how does this follow from the other change? This code is executed by both -break-list and -break-insert. By contrast, ISTR that in CLI, it is executed by "info break" but not break. As an alternative, I guess this line alone could be removed so that -break-insert lists the multiple breakpoint locations being set and the adjust MI documentation to explain this. In any case, I think deprecated_set_gdb_event_hooks should go. In CLI, breakpoint details are printed in mention with say_where=1. I don't really understand why things need to differently for MI or why it can't be done here too. -- Nick http://www.inet.net.nz/~nickrob