Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Maxim Grigoriev <maxim@tensilica.com>,
		gdb-patches@sources.redhat.com,
	Pete MacLiesh <pmac@tensilica.com>,
		Marc Gauthier <marc@tensilica.com>,
	Ross Morley <ross@tensilica.com>
Subject: Re: [PATCH] MI and MI2 should have identical behavior on 	-target-download  command
Date: Wed, 22 Aug 2007 05:33:00 -0000	[thread overview]
Message-ID: <18123.51896.668673.942676@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20070821132753.GA25612@caradoc.them.org>

 > -  if (current_interp_named_p (INTERP_MI))
 > +  if (current_interp_named_p (INTERP_MI)
 > +      || current_interp_named_p (INTERP_MI2))
 >      uiout = mi_out_new (2);
 >    else if (current_interp_named_p (INTERP_MI1))
 >      uiout = mi_out_new (1);
 > +  else if (current_interp_named_p (INTERP_MI3))
 > +    uiout = mi_out_new (3);
 >    else
 >      return;

Sorry, my comment was meant to be more general: What behaviour do you want for
miN?  where N >= 3.

Elsewhere GDB uses:

if (mi_version (uiout) < 2)

although that probably wouldn't work here.  I don't really no why GDB goes
through so many hoops with this.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2007-08-22  5:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 21:04 Maxim Grigoriev
2007-08-21 12:16 ` Nick Roberts
2007-08-21 13:28   ` Daniel Jacobowitz
2007-08-22  5:33     ` Nick Roberts [this message]
2007-08-22 11:09       ` Daniel Jacobowitz
2007-08-23  6:11         ` Nick Roberts
2007-08-23 11:48           ` Daniel Jacobowitz
2007-09-03 17:51     ` Daniel Jacobowitz
2007-08-21 17:43   ` Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18123.51896.668673.942676@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=marc@tensilica.com \
    --cc=maxim@tensilica.com \
    --cc=pmac@tensilica.com \
    --cc=ross@tensilica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox