From: Nick Roberts <nickrob@snap.net.nz>
To: Maxim Grigoriev <maxim@tensilica.com>
Cc: gdb-patches@sources.redhat.com,
Pete MacLiesh <pmac@tensilica.com>,
Marc Gauthier <marc@tensilica.com>,
Ross Morley <ross@tensilica.com>
Subject: Re: [PATCH] MI and MI2 should have identical behavior on -target-download command
Date: Tue, 21 Aug 2007 12:16:00 -0000 [thread overview]
Message-ID: <18122.55169.70021.143467@kahikatea.snap.net.nz> (raw)
In-Reply-To: <46CA01BF.3000501@hq.tensilica.com>
> It fixes a small glitch in GDB MI. MI2 is a default. So
> MI and MI2 should work identically. The MI2 being set as
> a default is hard-coded in several places. I think one
> place was missed:
>
> mi/mi-main.c::mi_load_progress().
>
> Without this fix, MI "-target-download" command behaves
> differently on MI versus MI2 not showing loading progress,
> when "-i=mi2" is used.
>
> GDB front-ends developers might want to stick with "-i=mi"
> assuming they always use a default. It would be a bad idea
> to force them to use explicit options like "-i=mi2".
What behaviour do you want for mi3?
>...
> - if (current_interp_named_p (INTERP_MI))
> + if (current_interp_named_p (INTERP_MI)
> + || current_interp_named_p (INTERP_MI2))
> uiout = mi_out_new (2);
> else if (current_interp_named_p (INTERP_MI1))
> uiout = mi_out_new (1);
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-08-21 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 21:04 Maxim Grigoriev
2007-08-21 12:16 ` Nick Roberts [this message]
2007-08-21 13:28 ` Daniel Jacobowitz
2007-08-22 5:33 ` Nick Roberts
2007-08-22 11:09 ` Daniel Jacobowitz
2007-08-23 6:11 ` Nick Roberts
2007-08-23 11:48 ` Daniel Jacobowitz
2007-09-03 17:51 ` Daniel Jacobowitz
2007-08-21 17:43 ` Maxim Grigoriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18122.55169.70021.143467@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=marc@tensilica.com \
--cc=maxim@tensilica.com \
--cc=pmac@tensilica.com \
--cc=ross@tensilica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox