From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7527 invoked by alias); 21 Aug 2007 12:16:16 -0000 Received: (qmail 7478 invoked by uid 22791); 21 Aug 2007 12:16:14 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Aug 2007 12:16:08 +0000 Received: from kahikatea.snap.net.nz (191.60.255.123.dynamic.snap.net.nz [123.255.60.191]) by viper.snap.net.nz (Postfix) with ESMTP id AB0493DA0DD; Wed, 22 Aug 2007 00:16:04 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 779AD8FC6D; Wed, 22 Aug 2007 00:16:01 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18122.55169.70021.143467@kahikatea.snap.net.nz> Date: Tue, 21 Aug 2007 12:16:00 -0000 To: Maxim Grigoriev Cc: gdb-patches@sources.redhat.com, Pete MacLiesh , Marc Gauthier , Ross Morley Subject: Re: [PATCH] MI and MI2 should have identical behavior on -target-download command In-Reply-To: <46CA01BF.3000501@hq.tensilica.com> References: <46CA01BF.3000501@hq.tensilica.com> X-Mailer: VM 7.19 under Emacs 22.1.50.11 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00411.txt.bz2 > It fixes a small glitch in GDB MI. MI2 is a default. So > MI and MI2 should work identically. The MI2 being set as > a default is hard-coded in several places. I think one > place was missed: > > mi/mi-main.c::mi_load_progress(). > > Without this fix, MI "-target-download" command behaves > differently on MI versus MI2 not showing loading progress, > when "-i=mi2" is used. > > GDB front-ends developers might want to stick with "-i=mi" > assuming they always use a default. It would be a bad idea > to force them to use explicit options like "-i=mi2". What behaviour do you want for mi3? >... > - if (current_interp_named_p (INTERP_MI)) > + if (current_interp_named_p (INTERP_MI) > + || current_interp_named_p (INTERP_MI2)) > uiout = mi_out_new (2); > else if (current_interp_named_p (INTERP_MI1)) > uiout = mi_out_new (1); -- Nick http://www.inet.net.nz/~nickrob