From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24497 invoked by alias); 22 Aug 2007 05:33:56 -0000 Received: (qmail 24388 invoked by uid 22791); 22 Aug 2007 05:33:55 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Aug 2007 05:33:51 +0000 Received: from kahikatea.snap.net.nz (18.41.255.123.static.snap.net.nz [123.255.41.18]) by viper.snap.net.nz (Postfix) with ESMTP id 098113D9F14; Wed, 22 Aug 2007 17:33:48 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 3DDB18FC6D; Wed, 22 Aug 2007 17:33:46 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18123.51896.668673.942676@kahikatea.snap.net.nz> Date: Wed, 22 Aug 2007 05:33:00 -0000 To: Daniel Jacobowitz Cc: Maxim Grigoriev , gdb-patches@sources.redhat.com, Pete MacLiesh , Marc Gauthier , Ross Morley Subject: Re: [PATCH] MI and MI2 should have identical behavior on -target-download command In-Reply-To: <20070821132753.GA25612@caradoc.them.org> References: <46CA01BF.3000501@hq.tensilica.com> <18122.55169.70021.143467@kahikatea.snap.net.nz> <20070821132753.GA25612@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 22.1.50.11 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00429.txt.bz2 > - if (current_interp_named_p (INTERP_MI)) > + if (current_interp_named_p (INTERP_MI) > + || current_interp_named_p (INTERP_MI2)) > uiout = mi_out_new (2); > else if (current_interp_named_p (INTERP_MI1)) > uiout = mi_out_new (1); > + else if (current_interp_named_p (INTERP_MI3)) > + uiout = mi_out_new (3); > else > return; Sorry, my comment was meant to be more general: What behaviour do you want for miN? where N >= 3. Elsewhere GDB uses: if (mi_version (uiout) < 2) although that probably wouldn't work here. I don't really no why GDB goes through so many hoops with this. -- Nick http://www.inet.net.nz/~nickrob