Re: [PATCH] Add DISABLE_COPY_AND_ASSIGN

[Pedro Alves <palves@redhat.com>]

On 07/18/2017 02:48 PM, Yao Qi wrote:
> We have many classes that copy cotr and assignment operator are deleted,
> so this patch adds a macro to do this, and replace these existing
> mechanical code with macro DISABLE_COPY_AND_ASSIGN.

Yes, please.  I've been meaning to add something like this for a while.

IMO, this could go in include/ansidecl.h, with a fallback version for
#if __cplusplus < C++11 that declares the methods without =delete (you
get a link error instead).

>  /* Pull in gdb::unique_xmalloc_ptr.  */
>  #include "common/gdb_unique_ptr.h"
>  
> +#define DISABLE_COPY_AND_ASSIGN(TYPE)		\
> +  TYPE (const TYPE&) = delete;			\
> +  void operator= (const TYPE &) = delete;
> +

Should this have an intro comment?

> --- a/gdb/common/refcounted-object.h
> +++ b/gdb/common/refcounted-object.h
> @@ -19,6 +19,8 @@
>  #ifndef REFCOUNTED_OBJECT_H
>  #define REFCOUNTED_OBJECT_H
>  
> +#include "common-defs.h"
> +

This should not be necessary (and is against the guidelines [1]),
since .c files must include defs.h/common-defs.h first thing.  Why did
you need it?

[1] https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files

Thanks,
Pedro Alves