From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105571 invoked by alias); 18 Jul 2017 14:22:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105462 invoked by uid 89); 18 Jul 2017 14:22:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jul 2017 14:22:20 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0001AC0587C4; Tue, 18 Jul 2017 14:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0001AC0587C4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0001AC0587C4 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D1EB6F92C; Tue, 18 Jul 2017 14:22:18 +0000 (UTC) Subject: Re: [PATCH] Add DISABLE_COPY_AND_ASSIGN To: Yao Qi , gdb-patches@sourceware.org References: <1500385686-19857-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <179e2d35-d903-1d6d-256a-063a35d677d2@redhat.com> Date: Tue, 18 Jul 2017 14:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1500385686-19857-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00255.txt.bz2 On 07/18/2017 02:48 PM, Yao Qi wrote: > We have many classes that copy cotr and assignment operator are deleted, > so this patch adds a macro to do this, and replace these existing > mechanical code with macro DISABLE_COPY_AND_ASSIGN. Yes, please. I've been meaning to add something like this for a while. IMO, this could go in include/ansidecl.h, with a fallback version for #if __cplusplus < C++11 that declares the methods without =delete (you get a link error instead). > /* Pull in gdb::unique_xmalloc_ptr. */ > #include "common/gdb_unique_ptr.h" > > +#define DISABLE_COPY_AND_ASSIGN(TYPE) \ > + TYPE (const TYPE&) = delete; \ > + void operator= (const TYPE &) = delete; > + Should this have an intro comment? > --- a/gdb/common/refcounted-object.h > +++ b/gdb/common/refcounted-object.h > @@ -19,6 +19,8 @@ > #ifndef REFCOUNTED_OBJECT_H > #define REFCOUNTED_OBJECT_H > > +#include "common-defs.h" > + This should not be necessary (and is against the guidelines [1]), since .c files must include defs.h/common-defs.h first thing. Why did you need it? [1] https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files Thanks, Pedro Alves