From: Libor Bukata via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435)
Date: Mon, 22 Feb 2021 12:03:54 +0100 [thread overview]
Message-ID: <179bcb0e-9b47-fac8-6a1a-21311efd8212@oracle.com> (raw)
In-Reply-To: <87a6rxku96.fsf@tromey.com>
Many thanks to Simon for the patch.
I confirm that it fixes the attach crash on Solaris x86/sparc.
The testsuite did not reveal any new regressions on Fedora Linux.
Regarding Solaris, the tests require much more time,
so, I will let you know when I have results.
AFAIK, the code changes look good.
Libor
On 2/21/21 10:04 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> Simon> Tested by trying to attach on a process on gcc211 on the gcc compile
> Simon> farm.
>
> Simon> gdb/ChangeLog:
>
> Simon> PR gdb/27435
> Simon> * inf-ptrace.c (struct target_unpusher): Move to target.h.
> Simon> (target_unpush_up): Likewise.
> Simon> * procfs.c (procfs_target::attach): Push target early. Use
> Simon> target_unpush_up to unpush target in case of error.
> Simon> * target.h (struct target_unpusher): Move here.
> Simon> (target_unpush_up): Likewise.
>
> FWIW this looks reasonable to me.
>
> Tom
next prev parent reply other threads:[~2021-02-22 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 15:56 Simon Marchi via Gdb-patches
2021-02-21 15:56 ` [PATCH 2/2] gdb: add asserts in thread code Simon Marchi via Gdb-patches
2021-02-21 21:04 ` [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) Tom Tromey
2021-02-21 21:18 ` Simon Marchi via Gdb-patches
2021-02-22 11:03 ` Libor Bukata via Gdb-patches [this message]
2021-02-22 16:51 ` Simon Marchi via Gdb-patches
2021-02-23 6:35 ` Libor Bukata via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179bcb0e-9b47-fac8-6a1a-21311efd8212@oracle.com \
--to=gdb-patches@sourceware.org \
--cc=libor.bukata@oracle.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox