From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vcd0KbaPM2DtWAAAWB0awg (envelope-from ) for ; Mon, 22 Feb 2021 06:04:22 -0500 Received: by simark.ca (Postfix, from userid 112) id 9B98C1EF78; Mon, 22 Feb 2021 06:04:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 12A5A1E789 for ; Mon, 22 Feb 2021 06:04:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46E71389364C; Mon, 22 Feb 2021 11:04:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46E71389364C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1613991860; bh=0DHh+9WkfSlXF62FwiK1VWCtMXD8Wx6NMGqYfJU3x3M=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=gz3V7AKXURS0pZpxq9p5Ks8s3InMXDpHl/5eoPVSD3n3q1mA6YlBJfbUxgsbfZB5Z HeNPJiSUMsZiN0f6XUSjCNcYEkPEqPvQUBpqKevlQJdANnflbjGqOOjpFgZ5bHOfoX fQwg2vy0tRWDLAVmF1+5Aq8ZvT5RDwRC9Wn4kZUc= Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by sourceware.org (Postfix) with ESMTPS id EA0903887027 for ; Mon, 22 Feb 2021 11:04:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EA0903887027 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11MB46Uf062686; Mon, 22 Feb 2021 11:04:06 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 36ttcm3812-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 11:04:06 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11MB04EZ082251; Mon, 22 Feb 2021 11:04:05 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by userp3020.oracle.com with ESMTP id 36uc6q6rdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 11:04:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0Fvl7U/TmRYSJ9hLsddI1UbDyWPMQafHEcgVk+sczSt4ute/PRT48NYZEYYn1W+egLmtaEbaOShKkxdrysCgYsZA6pSZMvFxtWoycs4NLwjfuJarJbCJpxI/xIwseKSf9LN/MIFWp9q2VlYBe+LwT6MLcN+lM8BP4yJy/UZDZ8K9brL+sRY/LjGxzDcckfKQhZ9rSSqjI2RK+ryT3HG8jUESM4vOwKC+RX0fmRzpKZ79XhifI53jICLzUjPLGEvFEn3NgMEkZDyY4DgBzJ+gL+xwB8zHnkXnmoE4Qti0VtdZ9XTSYp67j5hZ6pSwKgapnzs+GQFghYO+D7tf3CGlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DHh+9WkfSlXF62FwiK1VWCtMXD8Wx6NMGqYfJU3x3M=; b=ioUxtwTMGgAGMIBDOZp5UxfDS8CKGbn/s3zzPJX2fbC9AVcIfquLtZkWu5JAsutizRnj1cmit5pqD1AyyX8HuYkQtftnYRVXC/gqpMIdoFDKPNXtmKQojnbQ+JyvLq3VzAhlu1vxjH0ZjMqr9+Q/MrGYyuk/OmwdbaznhBY3JraEIJ1bsGh1+UAjcZSohBMeXBUUSD5wsbsOrsOLjVlQlQK6sBuRSA/yh+Wvt3JGHH11zqiVz7OxnU2mAUdTnLSFV8hjOl+SJE9taOKdjdNXUIUmOS/H+/7QX0wGicyjpROz4atDJvc9cytqyDMbRGW6zSh3VIeEAPNu1lB+ZzYTNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CH0PR10MB4937.namprd10.prod.outlook.com (2603:10b6:610:c5::24) by CH0PR10MB5034.namprd10.prod.outlook.com (2603:10b6:610:c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.31; Mon, 22 Feb 2021 11:04:01 +0000 Received: from CH0PR10MB4937.namprd10.prod.outlook.com ([fe80::39c4:a3c7:209b:99a7]) by CH0PR10MB4937.namprd10.prod.outlook.com ([fe80::39c4:a3c7:209b:99a7%7]) with mapi id 15.20.3868.033; Mon, 22 Feb 2021 11:04:01 +0000 Subject: Re: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) To: Tom Tromey , Simon Marchi via Gdb-patches References: <20210221155630.3026942-1-simon.marchi@polymtl.ca> <87a6rxku96.fsf@tromey.com> Message-ID: <179bcb0e-9b47-fac8-6a1a-21311efd8212@oracle.com> Date: Mon, 22 Feb 2021 12:03:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <87a6rxku96.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.75.191.143] X-ClientProxiedBy: ZR0P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::11) To CH0PR10MB4937.namprd10.prod.outlook.com (2603:10b6:610:c5::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.2] (188.75.191.143) by ZR0P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Mon, 22 Feb 2021 11:04:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ba5c653-80b7-4534-59d0-08d8d7218f74 X-MS-TrafficTypeDiagnostic: CH0PR10MB5034: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IBDQ0+C52bIrQ/TGLeVOoCMOFDv3ss8S1yxnol03U3QUrcfQAy784gOcK/KrQNggHxFb0RFYZIuT987zc8NLO4Tnu8EL8fk09ksPBi6WKehroELu4hoRCbUoluSdK1EZd22LEyCOTkwig+F7iRLKVTCsbmEGN8fcczoPjLhgtXwneAfMLeYBugmyM8IiW5OfDduM5dT///YqwnDZQ5/rsUUQzpd8TsiFdUezhHzcRuIBtoPYU+CRAmSow4oeljlu1tnENa7MopnQGYuu19qofP+JNWrGKPuuOM0sOP2uiGvqjD5WcsRDSQYr/YLwklKmQCmO3ouR7X459NjGxwKuT9C/vXueaZydgOrAM4//HuCA5ctKjva9OeTmK7mZUMW1ezJptGqjHL1x+UMVSzV7wdibHpa+y6tOG9pyzLE2Q20CCdx3EnzbL1zmhCoMSVk2MsiamB9yamShsvBqezHjxsEHCBkRZp4+iT1WgA1YQZS8IEOe7b7/hYcT+Q/LEEGPaCSa9J2CLP2jlXy4XPCE9jHTpBfYCz5LHUXxmxK7bCVKrTlQqGmdC+VpuTmBpyYIHlCT5jWyj2UNb24CZr8caW3ZJ+b6X4mPZi7Ocl+xb94= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR10MB4937.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(39860400002)(396003)(366004)(136003)(8676002)(31696002)(66476007)(66556008)(66946007)(31686004)(6666004)(478600001)(316002)(8936002)(16576012)(956004)(53546011)(110136005)(5660300002)(44832011)(86362001)(2616005)(83380400001)(26005)(36756003)(16526019)(186003)(4326008)(6486002)(2906002)(4744005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?S2tBb3VtMHJHakhhZ21ZWDNHT2ZWVGNYMGF4c2YrbGFuMlJNdmo5MUN3L0kr?= =?utf-8?B?dFJxdXkybytPZHhjL3dZS0krSkk0RS9WU3pNbnRXRU9YSUZSMEIrSHdCclho?= =?utf-8?B?OU5UdGJDeU8rQndERHNmS25WSjJnc2dsT2M0Z0dTYzJYRlZ6OFN0b25ZR255?= =?utf-8?B?VU84WkswdFRSZGVMcVFIOXo1VzAvN2FaQ0d2MFpUclROOGJ4T0hKS2pBalhX?= =?utf-8?B?TlV1T3VqLzhrUkdzRE44K3B2UC9idk1yNWxjcmlmUHB5MXVHUTMyOFZBVXIx?= =?utf-8?B?ZThKajIwY2VORDFFQ1RuMk5BUFBzMjNicUhhNFVPVGpCc1NxODkwU3h6ZkdT?= =?utf-8?B?N1Nvb2xlMWdJaW1DYW8vRmFLVjFiN215Y3JIZzZ6d2hKY29aSDVjZ0JCWmVu?= =?utf-8?B?dVUrcGlNU3NGSzdoakpIbHZCUHNlZXN2SmhwZXRLODdMUDRxeDBZOHBNTWgz?= =?utf-8?B?WFZYWHJONS9FWlg2ZGg5Rmo5WG9VeU83NCtuZ2w0MnNnYVRwSFpPM0ZGV1Bw?= =?utf-8?B?NEY4ek1Od0EwL1o2WmJ2RE1LRmZyWjlacEY5N0NsWU5ib2Q5dEZaQis0aWhy?= =?utf-8?B?YTVrQnppem5jek1nWGg3QjRQeWVnL2xPRndRRmdrbjhOU3ZlSnJ6bkp2Smo2?= =?utf-8?B?eVIvczhFWG83N1kzWnVXaXVhWVVObGpwY29IbXZRQlNaU2VVcC9tMTc5NzJO?= =?utf-8?B?ekpTQjk4d0RRTCs5YnBWWGs0Z1ZPZlQ2d2lCT2lwWi9xTVA4b3BIcVhVb29x?= =?utf-8?B?VVF4dWxydjFNazhqbnNHRFlJSmtxQTExTHNPR1UrdC9sL3c0bWFaV3JuQXU2?= =?utf-8?B?YkUzSHZ3YUg2cUxheGs4VkczSnRoN0FNaXVZOHdqU3daZG1hZW4zTSticmtJ?= =?utf-8?B?MDZwc3pKSERKdllOR3pkbG5ZRXBtUHRzZU9IL0VQYnZ0bjhSNGdmUmdRMnBi?= =?utf-8?B?WXpIb29qVWRnYmxjN282TlViYU5XY3NXSml2S2wzVDU0cm12cThHSTlIb1BE?= =?utf-8?B?R2d4WVpUeSt5cy9ZVWk3TnlvcHRrNFFrQmVjZ0lqWmoyUmVjUGdtdXhLMWp5?= =?utf-8?B?eGREQjVJTisyWkE5Z2ZCSUZ5YmNBQUl0Rm55cDdHcS92ZU5xL3FML2l1RjQr?= =?utf-8?B?aUVkU0pwclJRdWN0Z3pmWGRPdXoyN0MreFcvSENXd3FwbUZ0SmVGeCtrbXFE?= =?utf-8?B?NzA2UGxRd0RvYW40THVtL2hDbFFwTXYvTlJnZGZ4M2tqN3c0UXhYcURoMFdj?= =?utf-8?B?NC9tdllFWlJFUk5qejlRcE5NL0R6Q0UxaE1jQ1Rzd2phSHB6dzVsNW93a3Jk?= =?utf-8?B?dHlSK0Y4U3NrR0c1STRSUGtWT3ZUNkF2UE9NVlA1VFcyRFpBVklPU0FtSnR4?= =?utf-8?B?d0VqRHVJMlpaZ1Zya1hqMFA4enZaYVRjaW9UcXgwdDFXbGFoNzhvNys1d3pt?= =?utf-8?B?cTc0VzRaZzJCT3dka2g0RENjYVhwLzVmSGNDMjdpMmNhUlNTS2M3bWtaWE1M?= =?utf-8?B?Vi8wTHJQZW5qQWZxalZSY0FaRHgvSFFQRnFMWGwzVFZqeU9IRCsxQWhJM2ZI?= =?utf-8?B?cEl3QkFTeWZEOUs4TVowY29EeW9QcmoyOEtPVDByanA4M1JOUXRudDhtTGIx?= =?utf-8?B?Tk9IOHpWRUxnaHNiSCs2RmVhUmJrcWpWQTUvb1lFeEQ4MVN3VVUxZ3FBZkNE?= =?utf-8?B?ZmMwTkhiNkVNK1ZiNGdwazlmMzRaT09qaThNamRSeHRoM2VRM2ZxRTZRdkZu?= =?utf-8?Q?rW++CsJl6ssNLz5PE6iT8mPBr7A2Ducu/9Ntb4l?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba5c653-80b7-4534-59d0-08d8d7218f74 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4937.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2021 11:04:01.4764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GazS4dAllV0yL7XLF88lvkNH4QPVM0QuiBiYHPa9PU7bcQ5ZTcoanNjfsFsbXSIUCSjQAM/sX7SyfC6PXJKjpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5034 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9902 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220102 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9902 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220102 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Libor Bukata via Gdb-patches Reply-To: Libor Bukata Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Many thanks to Simon for the patch. I confirm that it fixes the attach crash on Solaris x86/sparc. The testsuite did not reveal any new regressions on Fedora Linux. Regarding Solaris, the tests require much more time, so, I will let you know when I have results. AFAIK, the code changes look good. Libor On 2/21/21 10:04 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > Simon> Tested by trying to attach on a process on gcc211 on the gcc compile > Simon> farm. > > Simon> gdb/ChangeLog: > > Simon> PR gdb/27435 > Simon> * inf-ptrace.c (struct target_unpusher): Move to target.h. > Simon> (target_unpush_up): Likewise. > Simon> * procfs.c (procfs_target::attach): Push target early. Use > Simon> target_unpush_up to unpush target in case of error. > Simon> * target.h (struct target_unpusher): Move here. > Simon> (target_unpush_up): Likewise. > > FWIW this looks reasonable to me. > > Tom