From: Libor Bukata via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435)
Date: Tue, 23 Feb 2021 07:35:20 +0100 [thread overview]
Message-ID: <a0560344-803c-655e-fe68-1faeb8b396c9@oracle.com> (raw)
In-Reply-To: <2f83e650-8ce1-4730-e815-6036e71eac9b@polymtl.ca>
Thank you for the integration. Unit tests did not reveal any new
regressions on Solaris.
Libor
On 2/22/21 5:51 PM, Simon Marchi wrote:
> On 2021-02-22 6:03 a.m., Libor Bukata wrote:> Many thanks to Simon for the patch.
>> I confirm that it fixes the attach crash on Solaris x86/sparc.
>> The testsuite did not reveal any new regressions on Fedora Linux.
>> Regarding Solaris, the tests require much more time,
>> so, I will let you know when I have results.
>>
>> AFAIK, the code changes look good.
> Thanks, I pushed the series to the master branch, and patch 1 to
> gdb-10-branch. Please let me know if you find unexpected regressions on
> Solaris (although hopefully, you'll see some tests going from FAIL to
> PASS).
>
> Simon
prev parent reply other threads:[~2021-02-23 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 15:56 Simon Marchi via Gdb-patches
2021-02-21 15:56 ` [PATCH 2/2] gdb: add asserts in thread code Simon Marchi via Gdb-patches
2021-02-21 21:04 ` [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) Tom Tromey
2021-02-21 21:18 ` Simon Marchi via Gdb-patches
2021-02-22 11:03 ` Libor Bukata via Gdb-patches
2021-02-22 16:51 ` Simon Marchi via Gdb-patches
2021-02-23 6:35 ` Libor Bukata via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0560344-803c-655e-fe68-1faeb8b396c9@oracle.com \
--to=gdb-patches@sourceware.org \
--cc=libor.bukata@oracle.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox