From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Fred Fish <fnf@specifix.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
gdb-patches@sources.redhat.com
Subject: Re: [RFC] Patch for QUIT macro support
Date: Thu, 08 Feb 2007 20:49:00 -0000 [thread overview]
Message-ID: <17867.36067.777579.739954@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20070208143336.GB6861@nevyn.them.org>
> > > We really should not put history in our comments.
> >
> > Good point. Here is a patch with updated comments.
> >
> > It would be good if someone could independently review, test, and
> > approve this, particularly anyone using an interface other than the
> > normal command line one.
>
> > 2007-01-22 Fred Fish <fnf@specifix.com>
> >
> > * event-top.c (handle_sigint): Set quit_flag.
> > (async_request_quit): Don't set quit_flag. Avoid calling quit()
> > if quit_flag has already been reset.
>
> Well, I independently reviewed it - I think this is correct. I
> can't readily test it with any other interface at the moment, but I
> think you should commit this. We'll have a while to catch any problems
> if there's something we didn't think of.
But this is really Apple's change isn't it? Even the comments (minus history)
are Apple's.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-02-08 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 12:43 Fred Fish
2006-10-13 13:22 ` Fred Fish
2006-10-13 13:30 ` Daniel Jacobowitz
2006-10-13 13:49 ` Fred Fish
2007-01-21 17:44 ` Daniel Jacobowitz
2007-01-21 19:23 ` Fred Fish
[not found] ` <200610151800.k9FI0fDS016688@elgar.sibelius.xs4all.nl>
2007-01-22 14:41 ` Fred Fish
2007-02-08 14:34 ` Daniel Jacobowitz
2007-02-08 20:49 ` Nick Roberts [this message]
2007-02-08 21:17 ` Fred Fish
2007-02-08 21:51 ` Nick Roberts
2006-10-13 14:58 ` Fred Fish
2007-02-08 14:34 ` Daniel Jacobowitz
2006-10-16 0:08 Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17867.36067.777579.739954@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=fnf@specifix.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox