From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29495 invoked by alias); 8 Feb 2007 20:49:52 -0000 Received: (qmail 29486 invoked by uid 22791); 8 Feb 2007 20:49:52 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Feb 2007 20:49:45 +0000 Received: from kahikatea.snap.net.nz (145.62.255.123.dynamic.snap.net.nz [123.255.62.145]) by viper.snap.net.nz (Postfix) with ESMTP id F2D0E3DA0C9; Fri, 9 Feb 2007 09:49:42 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 185A54F71B; Fri, 9 Feb 2007 09:49:41 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17867.36067.777579.739954@kahikatea.snap.net.nz> Date: Thu, 08 Feb 2007 20:49:00 -0000 To: Daniel Jacobowitz Cc: Fred Fish , Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [RFC] Patch for QUIT macro support In-Reply-To: <20070208143336.GB6861@nevyn.them.org> References: <200610130543.25806.fnf@specifix.com> <200610130648.31875.fnf@specifix.com> <200610151800.k9FI0fDS016688@elgar.sibelius.xs4all.nl> <200701220740.53051.fnf@specifix.com> <20070208143336.GB6861@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00101.txt.bz2 > > > We really should not put history in our comments. > > > > Good point. Here is a patch with updated comments. > > > > It would be good if someone could independently review, test, and > > approve this, particularly anyone using an interface other than the > > normal command line one. > > > 2007-01-22 Fred Fish > > > > * event-top.c (handle_sigint): Set quit_flag. > > (async_request_quit): Don't set quit_flag. Avoid calling quit() > > if quit_flag has already been reset. > > Well, I independently reviewed it - I think this is correct. I > can't readily test it with any other interface at the moment, but I > think you should commit this. We'll have a while to catch any problems > if there's something we didn't think of. But this is really Apple's change isn't it? Even the comments (minus history) are Apple's. -- Nick http://www.inet.net.nz/~nickrob