From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [ob] Fix mingw build
Date: Mon, 05 Feb 2007 21:33:00 -0000 [thread overview]
Message-ID: <17863.41600.734035.193757@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20070205132346.GA28998@nevyn.them.org>
> Our autotester broke after Nick's timings patch; we have a forward
> declaration of struct timeval, but not a full definition. This fixes
> it. We already include <sys/time.h> unconditionally in a number of
> other places.
I don't quite understand why it failed as the timeval members are only
accessed in mi-main.c which already included sys/time.h (for mi_load_progress).
> Index: mi/mi-parse.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/mi/mi-parse.h,v
> retrieving revision 1.7
> diff -u -p -r1.7 mi-parse.h
> --- mi/mi-parse.h 2 Feb 2007 23:01:27 -0000 1.7
> +++ mi/mi-parse.h 5 Feb 2007 13:20:56 -0000
> @@ -22,6 +22,8 @@
> #ifndef MI_PARSE_H
> #define MI_PARSE_H
>
> +#include <sys/time.h>
> +
> /* MI parser */
>
> /* Timestamps for current command and last asynchronous command. */
It's best here anyway. Although it doesn't break anything, maybe it should be
removed from mi-main.c now.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-02-05 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 13:23 Daniel Jacobowitz
2007-02-05 21:33 ` Nick Roberts [this message]
2007-02-05 21:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17863.41600.734035.193757@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox