From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16984 invoked by alias); 5 Feb 2007 21:33:02 -0000 Received: (qmail 16974 invoked by uid 22791); 5 Feb 2007 21:33:02 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Feb 2007 21:32:56 +0000 Received: from kahikatea.snap.net.nz (26.62.255.123.dynamic.snap.net.nz [123.255.62.26]) by viper.snap.net.nz (Postfix) with ESMTP id E1CE03D9D62; Tue, 6 Feb 2007 10:32:51 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 706AA4F703; Tue, 6 Feb 2007 10:32:50 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17863.41600.734035.193757@kahikatea.snap.net.nz> Date: Mon, 05 Feb 2007 21:33:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: [ob] Fix mingw build In-Reply-To: <20070205132346.GA28998@nevyn.them.org> References: <20070205132346.GA28998@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00045.txt.bz2 > Our autotester broke after Nick's timings patch; we have a forward > declaration of struct timeval, but not a full definition. This fixes > it. We already include unconditionally in a number of > other places. I don't quite understand why it failed as the timeval members are only accessed in mi-main.c which already included sys/time.h (for mi_load_progress). > Index: mi/mi-parse.h > =================================================================== > RCS file: /cvs/src/src/gdb/mi/mi-parse.h,v > retrieving revision 1.7 > diff -u -p -r1.7 mi-parse.h > --- mi/mi-parse.h 2 Feb 2007 23:01:27 -0000 1.7 > +++ mi/mi-parse.h 5 Feb 2007 13:20:56 -0000 > @@ -22,6 +22,8 @@ > #ifndef MI_PARSE_H > #define MI_PARSE_H > > +#include > + > /* MI parser */ > > /* Timestamps for current command and last asynchronous command. */ It's best here anyway. Although it doesn't break anything, maybe it should be removed from mi-main.c now. -- Nick http://www.inet.net.nz/~nickrob