From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sourceware.org
Subject: Re: [ob] Fix mingw build
Date: Mon, 05 Feb 2007 21:37:00 -0000 [thread overview]
Message-ID: <20070205213713.GA29839@nevyn.them.org> (raw)
In-Reply-To: <17863.41600.734035.193757@kahikatea.snap.net.nz>
On Tue, Feb 06, 2007 at 10:32:48AM +1300, Nick Roberts wrote:
> > Our autotester broke after Nick's timings patch; we have a forward
> > declaration of struct timeval, but not a full definition. This fixes
> > it. We already include <sys/time.h> unconditionally in a number of
> > other places.
>
> I don't quite understand why it failed as the timeval members are only
> accessed in mi-main.c which already included sys/time.h (for mi_load_progress).
Because struct mi_timestamp contains struct timeval members. If you
don't have a definition of the structure in scope, then it's
"incomplete" - the compiler does not know what size it is, so it can
not lay out a structure containing one.
> It's best here anyway. Although it doesn't break anything, maybe it should be
> removed from mi-main.c now.
I tend to leave it - that file will need it even if it's removed from
here for some reason.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-02-05 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 13:23 Daniel Jacobowitz
2007-02-05 21:33 ` Nick Roberts
2007-02-05 21:37 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205213713.GA29839@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox